From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36785 invoked by alias); 6 May 2015 10:37:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36761 invoked by uid 89); 6 May 2015 10:37:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 May 2015 10:37:22 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t46AbIeO016838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 May 2015 06:37:18 -0400 Received: from [10.36.7.202] (vpn1-7-202.ams2.redhat.com [10.36.7.202]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t46AbGIN008093 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 May 2015 06:37:17 -0400 Message-ID: <5549EEDC.7040707@redhat.com> Date: Wed, 06 May 2015 10:37:00 -0000 From: Nicholas Clifton User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Hans-Peter Nilsson , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: Fix sim fallout from arm assembler complaining about symbols named as insns References: <201505020017.t420Hn09026225@ignucius.se.axis.com> In-Reply-To: <201505020017.t420Hn09026225@ignucius.se.axis.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00092.txt.bz2 Hi Hans-Peter, > I'm not completely sure this new gas warning is a good thing. > I mean, symbols such as those below don't really interfere with > the insn namespace, do they? No, but they can be a little bit confusing and the problem I was trying to solve, of an instruction name being mistakenly treated as a symbol, is genuine. It would be better I agree to restrict this check to just the case where the "=" assignment operator is being used, but I did not want to modify generic code. Maybe I should have done that. :-( > To wit, right now, the new symbol "sanity-check" causes failures > for --target arm-eabi check-sim: So it does. I should have checked that before committing the patch. Sorry. > +2015-05-02 Hans-Peter Nilsson > + > + * bl.cgs (bl0): Rename from symbol colliding with insn name bl. > + * iwmmxt/tmia.cgs (tmia0): Similar. > + * iwmmxt/tmiaph.cgs (tmiaph0): Similar. > + * iwmmxt/waligni.cgs (waligni0): Similar. > + * iwmmxt/wand.cgs (wand0): Similar. > + * iwmmxt/wandn.cgs (wandn0): Similar. > + * iwmmxt/wmov.cgs (wmov0): Similar. > + * iwmmxt/wor.cgs (wor0): Similar. > + * iwmmxt/wshufh.cgs (wshuf0): Similar. > + * iwmmxt/wxor.cgs (wxor0): Similar. > + * iwmmxt/wzero.cgs (wzero0): Similar. > + * xscale/mia.cgs (mia0): Similar. > + * xscale/miaph.cgs (miaph0): Similar. I think that this is a good solution - please apply. Cheers Nick