From: Luis Machado <lgustavo@codesourcery.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code
Date: Thu, 07 May 2015 14:01:00 -0000 [thread overview]
Message-ID: <554B702F.5090006@codesourcery.com> (raw)
In-Reply-To: <554B4223.1000003@codesourcery.com>
On 05/07/2015 07:44 AM, Luis Machado wrote:
> On 05/07/2015 06:05 AM, Yao Qi wrote:
>> Luis Machado <lgustavo@codesourcery.com> writes:
>>
>>>>> -# Get the inferior's PID.
>>>>> -set infpid ""
>>>>> gdb_test_multiple "info inferiors" "getting inferior pid" {
>>>>> - -re "process \($decimal\).*\r\n$gdb_prompt $" {
>>>>> - set infpid $expect_out(1,string)
>>>>> + -re "process $decimal.*\r\n$gdb_prompt $" {
>>>>> }
>>>>> -re "Remote target.*$gdb_prompt $" {
>>>>> # If the target does not provide PID information (like
>>>>> usermode QEMU),
>>>>
>>>> This "If the target does not provide PID information" check sounds
>>>> odd now. Do we still need it?
>>>
>>> If we're not dealing with PID's, i don't think so.
>>
>> At the very start, I removed this block, but I recall that this block is
>> used as a guard for usermode QEMU which doesn't provide PID
>> information. With this patch applied, we'll access
>> /proc/self/coredump_filter, but I am afraid it doesn't work as expected
>> on usermode QEMU, because usermode QEMU just intercepts few /proc
>> accesses and pass most of them through the host linux. Accessing
>> /proc/QEMU_PID/coredump_filter isn't what we want in this test, so I
>> think it's better to skip the test for usermode QEMU.
>>
>> Of course, I don't mind removing this block. Luis, could you try this
>> patch and remove this block, see whether it causes fails on usermode
>> QEMU?
>>
>
> Yeah, that sounds problematic. I'll give it a try and will let you know.
Removing that conditional block i get 14 FAIL's, so it doesn't look like
this test is suited for usermode QEMU.
Besides that, without the conditional block i also see a problem with
the existing testcase using coredump_var_addr as an array but declaring
it as a regular variable. It causes a number of errors. Did you notice
that? Maybe it is specific to a certain version of expect.
# Obtain the address of each variable that will be checked on each
# case.
set coredump_var_addr ""
foreach item $all_anon_corefiles {
foreach name [list [lindex $item 3] [lindex $item 4]] {
set test "print/x $name"
gdb_test_multiple $test $test {
-re " = \($hex\)\r\n$gdb_prompt $" {
set coredump_var_addr($name) $expect_out(1,string)
}
}
}
}
next prev parent reply other threads:[~2015-05-07 14:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 15:29 Yao Qi
2015-05-06 16:12 ` Pedro Alves
2015-05-06 16:43 ` Luis Machado
2015-05-07 9:05 ` Yao Qi
2015-05-07 10:45 ` Luis Machado
2015-05-07 14:01 ` Luis Machado [this message]
2015-05-07 17:05 ` [PATCH] Fix coredump-filter.exp by correctly unsetting array (was: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code) Sergio Durigan Junior
2015-05-08 11:57 ` [PATCH] Fix coredump-filter.exp by correctly unsetting array Yao Qi
2015-05-08 17:23 ` Sergio Durigan Junior
2015-05-08 11:41 ` [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code Yao Qi
2015-05-08 14:40 ` Pedro Alves
2015-05-08 14:47 ` Luis Machado
2015-05-08 5:09 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B702F.5090006@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).