From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 815 invoked by alias); 7 May 2015 14:01:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 803 invoked by uid 89); 7 May 2015 14:01:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 May 2015 14:01:30 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YqMMg-0004ND-RE from Luis_Gustavo@mentor.com ; Thu, 07 May 2015 07:01:26 -0700 Received: from [172.30.2.216] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Thu, 7 May 2015 07:01:26 -0700 Message-ID: <554B702F.5090006@codesourcery.com> Date: Thu, 07 May 2015 14:01:00 -0000 From: Luis Machado Reply-To: Luis Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Yao Qi CC: Pedro Alves , Subject: Re: [rfc] Fix PR 18208: update /proc/pid/coredump_filter by c code References: <1429889336-12277-1-git-send-email-qiyaoltc@gmail.com> <554A3D61.8090302@redhat.com> <554A44B9.3090503@codesourcery.com> <86sib8vjtv.fsf@gmail.com> <554B4223.1000003@codesourcery.com> In-Reply-To: <554B4223.1000003@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00141.txt.bz2 On 05/07/2015 07:44 AM, Luis Machado wrote: > On 05/07/2015 06:05 AM, Yao Qi wrote: >> Luis Machado writes: >> >>>>> -# Get the inferior's PID. >>>>> -set infpid "" >>>>> gdb_test_multiple "info inferiors" "getting inferior pid" { >>>>> - -re "process \($decimal\).*\r\n$gdb_prompt $" { >>>>> - set infpid $expect_out(1,string) >>>>> + -re "process $decimal.*\r\n$gdb_prompt $" { >>>>> } >>>>> -re "Remote target.*$gdb_prompt $" { >>>>> # If the target does not provide PID information (like >>>>> usermode QEMU), >>>> >>>> This "If the target does not provide PID information" check sounds >>>> odd now. Do we still need it? >>> >>> If we're not dealing with PID's, i don't think so. >> >> At the very start, I removed this block, but I recall that this block is >> used as a guard for usermode QEMU which doesn't provide PID >> information. With this patch applied, we'll access >> /proc/self/coredump_filter, but I am afraid it doesn't work as expected >> on usermode QEMU, because usermode QEMU just intercepts few /proc >> accesses and pass most of them through the host linux. Accessing >> /proc/QEMU_PID/coredump_filter isn't what we want in this test, so I >> think it's better to skip the test for usermode QEMU. >> >> Of course, I don't mind removing this block. Luis, could you try this >> patch and remove this block, see whether it causes fails on usermode >> QEMU? >> > > Yeah, that sounds problematic. I'll give it a try and will let you know. Removing that conditional block i get 14 FAIL's, so it doesn't look like this test is suited for usermode QEMU. Besides that, without the conditional block i also see a problem with the existing testcase using coredump_var_addr as an array but declaring it as a regular variable. It causes a number of errors. Did you notice that? Maybe it is specific to a certain version of expect. # Obtain the address of each variable that will be checked on each # case. set coredump_var_addr "" foreach item $all_anon_corefiles { foreach name [list [lindex $item 3] [lindex $item 4]] { set test "print/x $name" gdb_test_multiple $test $test { -re " = \($hex\)\r\n$gdb_prompt $" { set coredump_var_addr($name) $expect_out(1,string) } } } }