From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106993 invoked by alias); 11 May 2015 11:39:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106947 invoked by uid 89); 11 May 2015 11:39:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=3.8 required=5.0 tests=AWL,BAYES_00,KAM_VERY_BLACK_DBL,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD,URIBL_BLACK,URIBL_DBL_SPAM autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 May 2015 11:39:00 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4BBctIt006193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 May 2015 07:38:55 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4BBcrc3000468; Mon, 11 May 2015 07:38:54 -0400 Message-ID: <555094CD.1020305@redhat.com> Date: Mon, 11 May 2015 11:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Sergio Durigan Junior , Gabriel Krisman Bertazi CC: gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v3 00/17] Catch syscall group References: <1430011521-24340-1-git-send-email-gabriel@krisman.be> <553F6BC0.9000905@redhat.com> <87r3r42e0v.fsf@redhat.com> <5540ABF8.4000404@redhat.com> <87k2wpt6k6.fsf@krisman.be> <554A275C.80204@redhat.com> <87r3qoi8n6.fsf@krisman.be> <87wq0gtfxu.fsf@redhat.com> In-Reply-To: <87wq0gtfxu.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00249.txt.bz2 On 05/10/2015 08:01 PM, Sergio Durigan Junior wrote: > On Sunday, May 10 2015, Gabriel Krisman Bertazi wrote: > >> I noticed that the GDB build step currently doesn't depend on xsltproc. >> It is used only in gdb/features/Makefile to generate some .dat files, >> that are also included in the repository at gdb/regformat. Am I right? > > Yes. This is a common practice inside GDB. > >> At first, I intended to use xsltproc as a build step and only provide >> the *.xml.in files in the repository. But that would have the side >> effect of forcing xsltproc to be available at build time, and I don't >> know if is acceptable. > > I don't see any reason to make GDB depend on xsltproc. You are > basically doing all this work because it makes things easier to > maintain, but there is no reason to force the user to install a XSLT > processor. > >> Other possibility would be to also push the generated files to the >> repository. We'd keep them in gdb/syscalls/generated/, or something >> like that, and have a script to update the xmls when needed. > > There is no reason to regenerate the XML files every time we build GDB, > because they would be the same every time, unless someone makes a > modification on the .in files. The same applies, for example, to > configure.ac or gdbarch.sh. > > This is the modus operandi here: put the generated files in the tree, > along with the templates. I am against creating a "generated/" > directory inside gdb/syscalls/. Just put the template files (*.in) in > the gdb/syscalls/ dir, and that's all. Don't forget to include a README > with instructions on how to regenerate the XML files. > Agreed. Thanks, Pedro Alves