From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41561 invoked by alias); 13 May 2015 10:30:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41523 invoked by uid 89); 13 May 2015 10:30:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 10:30:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id DA4E94B; Wed, 13 May 2015 10:29:59 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4DATuhg024826; Wed, 13 May 2015 06:29:57 -0400 Message-ID: <555327A4.7070408@redhat.com> Date: Wed, 13 May 2015 10:30:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gabriel Krisman Bertazi , sergiodj@redhat.com CC: gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v4 5/5] Update documentation on catching a group of related syscalls. References: <87wq0gtfxu.fsf@redhat.com> <1431304069-19647-1-git-send-email-gabriel@krisman.be> <1431304069-19647-6-git-send-email-gabriel@krisman.be> <874mnkhrpw.fsf@krisman.be> In-Reply-To: <874mnkhrpw.fsf@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00301.txt.bz2 On 05/11/2015 01:40 AM, Gabriel Krisman Bertazi wrote: > Gabriel Krisman Bertazi writes: > >> gdb/ >> >> * break-catch-syscall.c (_initialize_breakpoint): Update catch >> syscall command documentation. >> * NEWS: Include section about catching groups of syscalls. >> >> gdb/doc/ >> >> * gdb.texinfo (Set Catchpoints): Add 'group' argument to catch >> syscall. > > Oops, > > Sorry, I sent the documentation patch again. Please, ignore this one, > Eli already approved it twice. :) Generally, personally, in such cases, I prefer that an already approved patch is included in the series. That is, it makes it easier for people to review the whole series on its own. Don't assume that people still have context on previous discussions and patches in their heads. For example, I didn't really follow v1 and v2 closely (was OOO when most of the discussions happened, I think), and when I saw v3 I had to go hunt for the documentation patch. You can just mention in the patch intro that it is already approved. Thanks, Pedro Alves