From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7300 invoked by alias); 13 May 2015 10:43:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7287 invoked by uid 89); 13 May 2015 10:43:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD,URIBL_DBL_SPAM autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 10:43:04 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 5CCB98EFD4; Wed, 13 May 2015 10:43:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4DAh0LI011792; Wed, 13 May 2015 06:43:01 -0400 Message-ID: <55532AB3.7070304@redhat.com> Date: Wed, 13 May 2015 10:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gabriel Krisman Bertazi , sergiodj@redhat.com CC: gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v4 4/5] Include group information in xml syscall files. References: <87wq0gtfxu.fsf@redhat.com> <1431304069-19647-1-git-send-email-gabriel@krisman.be> <1431304069-19647-5-git-send-email-gabriel@krisman.be> In-Reply-To: <1431304069-19647-5-git-send-email-gabriel@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00303.txt.bz2 On 05/11/2015 01:27 AM, Gabriel Krisman Bertazi wrote: > We maintain linux-defaults.xml.in, a template file to hold generic group > information. It is used by the XSL script that parses the architecture > specific files to generate the final xml files, which are actually > installed and loaded by GDB. The script is not run during the build > process, and must be run manually by a GDB maintainer when there is need > to update the syscalls information files. > > gdb/ > > * syscalls/Makefile: New file. > * syscalls/apply-defaults.xsl: New file. > * syscalls/linux-defaults.xml.in: New file. > * syscalls/aarch64-linux.xml: Rename to aarch64-linux.xml.in. > * syscalls/amd64-linux.xml: Rename to amd64-linux.xml.in. > * syscalls/arm-linux.xml: Rename to arm-linux.xml.in. > * syscalls/bfin-linux.xml: Rename to bfin-linux.xml.in. > * syscalls/i386-linux.xml: Rename to i386-linux.xml.in. > * syscalls/mips-n32-linux.xml: Rename to mips-n32-linux.xml.in. > * syscalls/mips-n64-linux.xml: Rename to mips-n64-linux.xml.in. > * syscalls/mips-o32-linux.xml: Rename to mips-o32-linux.xml.in. > * syscalls/ppc-linux.xml: Rename to ppc-linux.xml.in. > * syscalls/ppc64-linux.xml: Rename to ppc64-linux.xml.in. > * syscalls/s390-linux.xml: Rename to s390-linux.xml.in. > * syscalls/s390x-linux.xml: Rename to s390x-linux.xml.in. > * syscalls/sparc-linux.xml: Rename to sparc-linux.xml.in. > * syscalls/sparc64-linux.xml: Rename to sparc64-linux.xml.in. > --- > gdb/syscalls/Makefile | 41 ++++ > .../{aarch64-linux.xml => aarch64-linux.xml.in} | 0 > .../{amd64-linux.xml => amd64-linux.xml.in} | 0 > gdb/syscalls/apply-defaults.xsl | 27 +++ > gdb/syscalls/{arm-linux.xml => arm-linux.xml.in} | 0 > gdb/syscalls/{bfin-linux.xml => bfin-linux.xml.in} | 0 > gdb/syscalls/{i386-linux.xml => i386-linux.xml.in} | 0 > gdb/syscalls/linux-defaults.xml.in | 243 +++++++++++++++++++++ > .../{mips-n32-linux.xml => mips-n32-linux.xml.in} | 0 > .../{mips-n64-linux.xml => mips-n64-linux.xml.in} | 0 > .../{mips-o32-linux.xml => mips-o32-linux.xml.in} | 0 > gdb/syscalls/{ppc-linux.xml => ppc-linux.xml.in} | 0 > .../{ppc64-linux.xml => ppc64-linux.xml.in} | 0 > gdb/syscalls/{s390-linux.xml => s390-linux.xml.in} | 0 > .../{s390x-linux.xml => s390x-linux.xml.in} | 0 > .../{sparc-linux.xml => sparc-linux.xml.in} | 0 > .../{sparc64-linux.xml => sparc64-linux.xml.in} | 0 > 17 files changed, 311 insertions(+) > create mode 100644 gdb/syscalls/Makefile > rename gdb/syscalls/{aarch64-linux.xml => aarch64-linux.xml.in} (100%) > rename gdb/syscalls/{amd64-linux.xml => amd64-linux.xml.in} (100%) > create mode 100644 gdb/syscalls/apply-defaults.xsl > rename gdb/syscalls/{arm-linux.xml => arm-linux.xml.in} (100%) > rename gdb/syscalls/{bfin-linux.xml => bfin-linux.xml.in} (100%) > rename gdb/syscalls/{i386-linux.xml => i386-linux.xml.in} (100%) > create mode 100644 gdb/syscalls/linux-defaults.xml.in > rename gdb/syscalls/{mips-n32-linux.xml => mips-n32-linux.xml.in} (100%) > rename gdb/syscalls/{mips-n64-linux.xml => mips-n64-linux.xml.in} (100%) > rename gdb/syscalls/{mips-o32-linux.xml => mips-o32-linux.xml.in} (100%) > rename gdb/syscalls/{ppc-linux.xml => ppc-linux.xml.in} (100%) > rename gdb/syscalls/{ppc64-linux.xml => ppc64-linux.xml.in} (100%) > rename gdb/syscalls/{s390-linux.xml => s390-linux.xml.in} (100%) > rename gdb/syscalls/{s390x-linux.xml => s390x-linux.xml.in} (100%) > rename gdb/syscalls/{sparc-linux.xml => sparc-linux.xml.in} (100%) > rename gdb/syscalls/{sparc64-linux.xml => sparc64-linux.xml.in} (100%) > > diff --git a/gdb/syscalls/Makefile b/gdb/syscalls/Makefile > new file mode 100644 > index 0000000..30fa4e4 > --- /dev/null > +++ b/gdb/syscalls/Makefile > @@ -0,0 +1,41 @@ > +# Copyright (C) 2007-2015 Free Software Foundation, Inc. > + > +# This file is part of GDB. > + > +# This program is free software; you can redistribute it and/or modify > +# it under the terms of the GNU General Public License as published by > +# the Free Software Foundation; either version 3 of the License, or > +# (at your option) any later version. > +# > +# This program is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > +# GNU General Public License for more details. > +# > +# You should have received a copy of the GNU General Public License > +# along with this program. If not, see . > + > +# This file requires GNU make! > + > +# This Makefile generates the XML syscall files from their xml.in and > +# *-defaults.xml counterparts. Because this relies on xsltproc, it is > +# not normally run during the build process; it should be run by hand > +# when one of the affected source files is changed, and the results > +# should be kept in the GDB repository. > + > +# To generate the updated xml files, just enter the syscalls directory > +# and run > +# > +# $ make > + > +XSLTPROC = xsltproc > +SYSCALL_FILES = aarch64-linux.xml arm-linux.xml mips-n64-linux.xml \ > + ppc64-linux.xml s390-linux.xml sparc64-linux.xml \ > + amd64-linux.xml bfin-linux.xml i386-linux.xml \ > + mips-n32-linux.xml mips-o32-linux.xml ppc-linux.xml \ > + s390x-linux.xml sparc-linux.xml > + > +all: $(SYSCALL_FILES) > + > +%.xml: %.xml.in apply-defaults.xsl linux-defaults.xml.in > + $(XSLTPROC) -o $@ apply-defaults.xsl $< > diff --git a/gdb/syscalls/aarch64-linux.xml b/gdb/syscalls/aarch64-linux.xml.in > similarity index 100% > rename from gdb/syscalls/aarch64-linux.xml > rename to gdb/syscalls/aarch64-linux.xml.in > diff --git a/gdb/syscalls/amd64-linux.xml b/gdb/syscalls/amd64-linux.xml.in > similarity index 100% > rename from gdb/syscalls/amd64-linux.xml > rename to gdb/syscalls/amd64-linux.xml.in > diff --git a/gdb/syscalls/apply-defaults.xsl b/gdb/syscalls/apply-defaults.xsl > new file mode 100644 > index 0000000..5b7f224 > --- /dev/null > +++ b/gdb/syscalls/apply-defaults.xsl > @@ -0,0 +1,27 @@ > + > + > + + xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > diff --git a/gdb/syscalls/arm-linux.xml b/gdb/syscalls/arm-linux.xml.in > similarity index 100% > rename from gdb/syscalls/arm-linux.xml > rename to gdb/syscalls/arm-linux.xml.in > diff --git a/gdb/syscalls/bfin-linux.xml b/gdb/syscalls/bfin-linux.xml.in > similarity index 100% > rename from gdb/syscalls/bfin-linux.xml > rename to gdb/syscalls/bfin-linux.xml.in > diff --git a/gdb/syscalls/i386-linux.xml b/gdb/syscalls/i386-linux.xml.in > similarity index 100% > rename from gdb/syscalls/i386-linux.xml > rename to gdb/syscalls/i386-linux.xml.in > diff --git a/gdb/syscalls/linux-defaults.xml.in b/gdb/syscalls/linux-defaults.xml.in > new file mode 100644 > index 0000000..576be0c > --- /dev/null > +++ b/gdb/syscalls/linux-defaults.xml.in > @@ -0,0 +1,243 @@ > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + > + Looks like a stale 'number="6281"' sneaked in here. Otherwise this looks good to me. Thanks for doing this. Thanks, Pedro Alves