From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8294 invoked by alias); 13 May 2015 12:57:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8253 invoked by uid 89); 13 May 2015 12:57:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 12:57:21 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 75248BDD7B for ; Wed, 13 May 2015 12:57:20 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4DCvI1l021819; Wed, 13 May 2015 08:57:19 -0400 Message-ID: <55534A2E.5020608@redhat.com> Date: Wed, 13 May 2015 12:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Call dummy_frame_dtor_ftype also from remove_dummy_frame References: <20150508202119.15830.18218.stgit@host1.jankratochvil.net> <20150508202128.15830.40142.stgit@host1.jankratochvil.net> In-Reply-To: <20150508202128.15830.40142.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00306.txt.bz2 On 05/08/2015 09:21 PM, Jan Kratochvil wrote: > Hi, > > there was now a leak-like bug that if dummy_frame "disappeared" by > remove_dummy_frame then its destructor was not called. For example in the case > of 'compile code' dummy frames the injected objfile would never get freed after > some inferior longjmp out of the injected code. So the real fix here is this bit, right? > /* Arbitrary data that is passed to DTOR. */ > @@ -96,6 +96,9 @@ remove_dummy_frame (struct dummy_frame **dummy_ptr) > { > struct dummy_frame *dummy = *dummy_ptr; > > + if (dummy->dtor != NULL) > + dummy->dtor (dummy->dtor_data, 0); > + I'm not seeing where registers_valid is used anywhere in this patch. Guess it'll be used in follow up patches. (A clearer patch split would have added the missing dummy->dtor call in this patch, and left the registers_valid addition to a separate patch that needs that.) /me goes try to understand the rest of the series. Thanks, Pedro Alves