From: Pedro Alves <palves@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 6/6] Make regcache_cpy_no_passthrough static
Date: Wed, 13 May 2015 13:16:00 -0000 [thread overview]
Message-ID: <55534EBA.9030700@redhat.com> (raw)
In-Reply-To: <20150508202159.15830.97494.stgit@host1.jankratochvil.net>
On 05/08/2015 09:21 PM, Jan Kratochvil wrote:
> +/* Copy/duplicate the contents of a register cache. By default, the
> + operation is pass-through. Writes to DST and reads from SRC will
> + go through to the target. See also regcache_cpy.
> +
> + It can not have overlapping SRC and DST buffers.
> +
> + It does not go through to the target. It only transfer values
> + already in the cache. */
I think this would be clearer:
/* Copy/duplicate the contents of a register cache. Unlike regcache_cpy,
which is pass-through, this does not go through to the target.
Only values values already in the cache are transferred. The SRC and DST
buffers must not overlap. */
static void
regcache_cpy_no_passthrough (struct regcache *dst, struct regcache *src)
{
Otherwise looks fine.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-05-13 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 20:21 [PATCH 1/6] dummy_frame_dtor_ftype vs. call_function_by_hand_dummy_dtor_ftype cleanup Jan Kratochvil
2015-05-08 20:21 ` [PATCH 4/6] infcall: stop_registers -> register_dummy_frame_dtor Jan Kratochvil
2015-05-13 13:28 ` Pedro Alves
2015-05-13 18:54 ` [commit] " Jan Kratochvil
2015-05-08 20:21 ` [PATCH 3/6] register_dummy_frame_dtor: Permit multiple dtors Jan Kratochvil
2015-05-13 13:00 ` Pedro Alves
2015-05-13 19:50 ` [commit] " Jan Kratochvil
2015-05-08 20:21 ` [PATCH 2/6] Call dummy_frame_dtor_ftype also from remove_dummy_frame Jan Kratochvil
2015-05-13 12:57 ` Pedro Alves
2015-05-13 13:52 ` Jan Kratochvil
2015-05-13 18:53 ` [commit] " Jan Kratochvil
2015-05-08 20:21 ` [PATCH 5/6] Remove stop_registers Jan Kratochvil
2015-05-13 13:10 ` Pedro Alves
2015-05-13 18:55 ` [commit] " Jan Kratochvil
2015-05-08 20:22 ` [PATCH 6/6] Make regcache_cpy_no_passthrough static Jan Kratochvil
2015-05-13 13:16 ` Pedro Alves [this message]
2015-05-13 19:49 ` [commit] " Jan Kratochvil
2015-05-13 12:55 ` [PATCH 1/6] dummy_frame_dtor_ftype vs. call_function_by_hand_dummy_dtor_ftype cleanup Pedro Alves
2015-05-13 13:56 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55534EBA.9030700@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).