From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Move vgdb special case into remote_filesystem_is_local
Date: Thu, 14 May 2015 10:44:00 -0000 [thread overview]
Message-ID: <55547C8B.5050000@redhat.com> (raw)
In-Reply-To: <1430146276-15606-1-git-send-email-gbenson@redhat.com>
On 04/27/2015 03:51 PM, Gary Benson wrote:
> Hi all,
>
> Valgrind GDB (vgdb) presents itself as a remote target but works on
> the local filesystem. gdb_bfd_open contained a special case to make
> vgdb work with "target:" sysroots, but the implementation meant that
> GDB would fall back to the local filesystem if *any* to_fileio_open
> method failed with ENOSYS for *any* reason.
Can you give an example target where we'd want this to behave differently?
E.g,. what should happen with "target sim" ?
> This commit moves the
> vgdb special case to remote_filesystem_is_local to allow the fallback
> to be restricted only to the specific case that remote file transfer
> is unsupported. This commit also adds a warning which is displayed
> the first time the fallback is used.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-05-14 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 14:51 Gary Benson
2015-05-07 10:09 ` [PING][PATCH] " Gary Benson
2015-05-14 10:44 ` Pedro Alves [this message]
2015-05-15 9:02 ` [PATCH] " Gary Benson
2015-05-15 11:32 ` Pedro Alves
2015-05-15 13:19 ` Gary Benson
2015-05-19 11:10 ` Pedro Alves
2015-05-27 9:50 ` Gary Benson
2015-06-05 15:13 ` [pushed] " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55547C8B.5050000@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).