From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72301 invoked by alias); 20 May 2015 12:16:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72288 invoked by uid 89); 20 May 2015 12:15:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 May 2015 12:15:58 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Yv2ug-0003se-PR from Luis_Gustavo@mentor.com ; Wed, 20 May 2015 05:15:54 -0700 Received: from [172.30.5.161] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Wed, 20 May 2015 05:15:54 -0700 Message-ID: <555C7AF7.7060908@codesourcery.com> Date: Wed, 20 May 2015 12:16:00 -0000 From: Luis Machado Reply-To: Luis Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's References: <1431020207-14371-1-git-send-email-lgustavo@codesourcery.com> <1431020207-14371-2-git-send-email-lgustavo@codesourcery.com> <20150508172831.GC4767@adacore.com> <554CFF15.1090206@codesourcery.com> <20150511205541.GF4767@adacore.com> In-Reply-To: <20150511205541.GF4767@adacore.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00517.txt.bz2 On 05/11/2015 05:55 PM, Joel Brobecker wrote: >> On 05/08/2015 02:28 PM, Joel Brobecker wrote: >>>> gdb/ChangeLog: >>>> >>>> 2015-05-07 Luis Machado >>>> >>>> * gdb/mi/mi-cmd-var.c (mi_parse_format): Handle new "zero-hexadecimal" >>>> format. >>>> * gdb/varobj.c (varobj_format_string): Add "zero-hexadecimal" entry. >>>> (format_code): Add 'z' entry. >>>> (varobj_set_display_format): Handle FORMAT_ZHEXADECIMAL. >>>> * gdb/varobj.h (varobj_display_formats) : New enum >>>> field. >>> >>> I don't normally have authority to approve, but the patch looks >>> sufficiently mechanical that I think I can provide approval if >>> the area maintainer isn't available. > [...] >> I've updated the patch with your suggestions now. > > Thanks, Luis. FWIW, the patch looks good to me. Let's wait one more > week for the MI maintainer to give any feedback, but otherwise just > go ahead and push (based on the fact that it's fairly consistent with > what we already have, and a fairly mechanical change). > Thanks Joel. I'll push this one until the end of the week.