From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72922 invoked by alias); 21 May 2015 13:17:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72835 invoked by uid 89); 21 May 2015 13:17:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 13:17:17 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4LDHFeY020506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2015 09:17:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LDHD00031711; Thu, 21 May 2015 09:17:14 -0400 Message-ID: <555DDAD8.2030109@redhat.com> Date: Thu, 21 May 2015 13:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrew Burgess , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] gdb: Remove register class specific layout names. References: <90740f3ef5bac701c1653d469fcc9d34fb113517.1432163460.git.andrew.burgess@embecosm.com> <20150521122510.GJ2880@embecosm.com> In-Reply-To: <20150521122510.GJ2880@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00536.txt.bz2 On 05/21/2015 01:25 PM, Andrew Burgess wrote: > > * Pedro Alves [2015-05-21 09:12:45 +0100]: >> Doesn't your series effectively make this bit in display_command dead? >> (while before it would switch on the registers layout). > > Sorry for missing that use. > > You're right, it's certainly dead now, though before my patch it still > didn't do anything, passing the '$FREGS', etc names to > tui_set_layout_for_display_command would just cause the regs display > to pop up with the default register set. (At least, that's all I > ever see, and I don't think anything else is possible.) Right, that's what I saw. > > Given that it's not worked for a while, I propose to just remove the > above snippet (really having this in display seems nasty to me) and > just move to layout being for layout adjustment, and 'tui reg' to > change the displayed register set. Agreed. > >> (We should probably >> rename tui_set_layout_for_display_command too.) > > Done, it's now tui_set_layout_by_name. > >> I had never noticed these special register layouts before either. I'm not >> at all adverse to removing them. Not all expressions that start with $ are >> registers, and probably a better idea would be to have >> a separate "displays" window (so displays would go to that window >> instead of the command window when the TUI is active), so that the tui >> could neatly show watched variables/random expressions too. > > Sounds like a good idea. > > New patch below. OK. Thanks, Pedro Alves