From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44405 invoked by alias); 21 May 2015 17:46:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44391 invoked by uid 89); 21 May 2015 17:46:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 17:46:38 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0B44F3C225; Thu, 21 May 2015 17:46:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHkZjq022476; Thu, 21 May 2015 13:46:36 -0400 Message-ID: <555E19FB.9030709@redhat.com> Date: Thu, 21 May 2015 17:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 5/7] target: consider addressable unit size when reading/writing memory References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-6-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1429127258-1033-6-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00549.txt.bz2 On 04/15/2015 08:47 PM, Simon Marchi wrote: > If we are reading/writing from a memory object, the length represents > the number of "addresses" to read/write, so the addressable unit size > needs to be taken into account when allocating memory on gdb's side. > > gdb/ChangeLog: > > * target.c (target_read): Consider addressable unit size when > reading from a memory object. > (read_memory_robust): Same. > (read_whatever_is_readable): Same. > (target_write_with_progress): Consider addressable unit size > when writing to a memory object. > * target.h (target_read): Update documentation. > (target_write): Add documentation. > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -1589,6 +1589,15 @@ target_read (struct target_ops *ops, > ULONGEST offset, LONGEST len) > { > LONGEST xfered_total = 0; > + int unit_size = 1; > + > + /* If we are reading from a memory object, find the length of an addressable > + unit for that architecture. */ > + if (object == TARGET_OBJECT_MEMORY > + || object == TARGET_OBJECT_STACK_MEMORY > + || object == TARGET_OBJECT_CODE_MEMORY > + || object == TARGET_OBJECT_RAW_MEMORY) > + unit_size = gdbarch_addressable_memory_unit_size (target_gdbarch()); Missing space before parens. Otherwise looks OK. Thanks, Pedro Alves