From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory
Date: Thu, 21 May 2015 17:48:00 -0000 [thread overview]
Message-ID: <555E1A50.7020007@redhat.com> (raw)
In-Reply-To: <1429127258-1033-7-git-send-email-simon.marchi@ericsson.com>
On 04/15/2015 08:47 PM, Simon Marchi wrote:
> Adapt code in remote.c to take into account addressable unit size when
> reading/writing memory.
>
> A few variables are renamed and suffixed with _bytes or _units. This
> way, it's more obvious if there is any place where we add or compare
> values of different kinds (which would be a mistake).
You should put here some of the info you have on the series intro.
Even better in comments in the code even.
E.g., this example here:
> For RSP's m, M and X packets, the "length" parameters are used to
> correctly encode or decode the packet at a low level, where we don't
> want to have to deal with different target byte sizes. Also, for a
> network protocol, it would make sense to use a fixed-sized unit.
> Therefore, it would be easier if those lengths were always in bytes.
> Here is an example that corresponds to the previous MI example.
>
> -> $m1000,8#??
> <- aaaabbbbccccdddd
>
> -> $M1000,6:eeeeffffeeee#??
> <- OK
>
> -> $m1000,8#??
> <- eeeeffffeeeedddd
>
> --- a/gdb/common/rsp-low.c
> +++ b/gdb/common/rsp-low.c
> @@ -146,38 +146,64 @@ bin2hex (const gdb_byte *bin, char *hex, int count)
> return i;
> }
>
> +static int needs_escaping (gdb_byte b)
Line break before 'needs_escaping'. Missing intro comment.
> +{
> + return b == '$' || b == '#' || b == '}' || b == '*';
> +}
> +
> - if (output_index + 1 > out_maxlen)
> - break;
> - out_buf[output_index++] = b;
> + int idx = input_unit_index * unit_size + byte_index_in_unit;
> + gdb_byte b = buffer[idx];
> + if (needs_escaping(b))
Space before parens.
> + {
Otherwise looks good.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-05-21 17:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 19:47 [PATCH v2 0/7] Support reading/writing memory on architectures with non 8-bits addressable memory Simon Marchi
2015-04-15 19:47 ` [PATCH v2 3/7] Clarify doc about memory read/write and non-8-bits addressable memory unit sizes Simon Marchi
2015-04-16 14:48 ` Eli Zaretskii
2015-06-12 20:28 ` Simon Marchi
2015-06-13 6:49 ` Eli Zaretskii
2015-06-15 17:40 ` Simon Marchi
2015-06-15 18:09 ` Eli Zaretskii
2015-06-15 19:38 ` Simon Marchi
2015-04-15 19:47 ` [PATCH v2 1/7] Various cleanups in target read/write code Simon Marchi
2015-05-21 17:45 ` Pedro Alves
2015-06-12 17:09 ` Simon Marchi
2015-04-15 19:47 ` [PATCH v2 5/7] target: consider addressable unit size when reading/writing memory Simon Marchi
2015-05-21 17:46 ` Pedro Alves
2015-06-12 21:07 ` Simon Marchi
2015-04-15 19:48 ` [PATCH v2 2/7] Cleanup some docs about memory write Simon Marchi
2015-05-21 17:45 ` Pedro Alves
2015-06-12 19:17 ` Simon Marchi
2015-06-15 9:57 ` Pedro Alves
2015-06-15 17:36 ` Simon Marchi
2015-04-15 19:48 ` [PATCH v2 4/7] gdbarch: add addressable_memory_unit_size method Simon Marchi
2015-05-21 17:46 ` Pedro Alves
2015-06-12 20:54 ` Simon Marchi
2015-04-15 19:48 ` [PATCH v2 7/7] MI: consider addressable unit size when reading/writing memory Simon Marchi
2015-05-21 17:52 ` Pedro Alves
2015-06-15 19:51 ` Simon Marchi
2015-04-15 19:48 ` [PATCH v2 6/7] remote: " Simon Marchi
2015-05-21 17:48 ` Pedro Alves [this message]
2015-06-15 19:28 ` Simon Marchi
2015-06-17 11:55 ` Pedro Alves
2015-06-18 17:14 ` Simon Marchi
2015-05-21 17:44 ` [PATCH v2 0/7] Support reading/writing memory on architectures with non 8-bits addressable memory Pedro Alves
2015-06-11 21:06 ` Simon Marchi
2015-06-11 21:10 ` Simon Marchi
2015-06-12 12:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555E1A50.7020007@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).