From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71584 invoked by alias); 21 May 2015 17:48:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71575 invoked by uid 89); 21 May 2015 17:48:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 17:48:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHm2Hr023731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2015 13:48:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHm0tg019876; Thu, 21 May 2015 13:48:01 -0400 Message-ID: <555E1A50.7020007@redhat.com> Date: Thu, 21 May 2015 17:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-7-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1429127258-1033-7-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00550.txt.bz2 On 04/15/2015 08:47 PM, Simon Marchi wrote: > Adapt code in remote.c to take into account addressable unit size when > reading/writing memory. > > A few variables are renamed and suffixed with _bytes or _units. This > way, it's more obvious if there is any place where we add or compare > values of different kinds (which would be a mistake). You should put here some of the info you have on the series intro. Even better in comments in the code even. E.g., this example here: > For RSP's m, M and X packets, the "length" parameters are used to > correctly encode or decode the packet at a low level, where we don't > want to have to deal with different target byte sizes. Also, for a > network protocol, it would make sense to use a fixed-sized unit. > Therefore, it would be easier if those lengths were always in bytes. > Here is an example that corresponds to the previous MI example. > > -> $m1000,8#?? > <- aaaabbbbccccdddd > > -> $M1000,6:eeeeffffeeee#?? > <- OK > > -> $m1000,8#?? > <- eeeeffffeeeedddd > > --- a/gdb/common/rsp-low.c > +++ b/gdb/common/rsp-low.c > @@ -146,38 +146,64 @@ bin2hex (const gdb_byte *bin, char *hex, int count) > return i; > } > > +static int needs_escaping (gdb_byte b) Line break before 'needs_escaping'. Missing intro comment. > +{ > + return b == '$' || b == '#' || b == '}' || b == '*'; > +} > + > - if (output_index + 1 > out_maxlen) > - break; > - out_buf[output_index++] = b; > + int idx = input_unit_index * unit_size + byte_index_in_unit; > + gdb_byte b = buffer[idx]; > + if (needs_escaping(b)) Space before parens. > + { Otherwise looks good. Thanks, Pedro Alves