Re: [PATCH 1/2] gdb: Add 'tui reg prev' command.

[Pedro Alves <palves@redhat.com>]

On 05/22/2015 05:37 PM, Andrew Burgess wrote:

> New version.  I've addressed your comments from the first review.  The
> reggroup_prev iterator has been fixed along the lines you suggested.
> 

Great, thanks.

> +/* Implementation of the "tui reg prev" command.  Cycle the register group
> +   displayed in the tui REG window, moving backwards through the list of
> +   available register groups.  */
> +
> +static void
> +tui_reg_prev_command (char *arg, int from_tty)
> +{
> +  struct gdbarch *gdbarch = get_current_arch ();
> +
> +  if (TUI_DATA_WIN != NULL)
> +    {
> +      struct reggroup *group
> +        = TUI_DATA_WIN->detail.data_display_info.current_group;
> +
> +      group = reggroup_prev (gdbarch, group);
> +      if (group == NULL)
> +	group = reggroup_prev (gdbarch, NULL);
> +
> +      if (group)

group != NULL.

> +        tui_show_registers (group);

Indentation looks odd here.

Otherwise OK.

Thanks,
Pedro Alves