Re: [PATCH v2 1/3] Add zero-padded hexadecimal format support for varobj's

[Luis Machado <lgustavo@codesourcery.com>]

On 05/20/2015 09:15 AM, Luis Machado wrote:
> On 05/11/2015 05:55 PM, Joel Brobecker wrote:
>>> On 05/08/2015 02:28 PM, Joel Brobecker wrote:
>>>>> gdb/ChangeLog:
>>>>>
>>>>> 2015-05-07  Luis Machado  <lgustavo@codesourcery.com>
>>>>>
>>>>>     * gdb/mi/mi-cmd-var.c (mi_parse_format): Handle new
>>>>> "zero-hexadecimal"
>>>>>     format.
>>>>>     * gdb/varobj.c (varobj_format_string): Add "zero-hexadecimal"
>>>>> entry.
>>>>>     (format_code): Add 'z' entry.
>>>>>     (varobj_set_display_format): Handle FORMAT_ZHEXADECIMAL.
>>>>>     * gdb/varobj.h (varobj_display_formats) <FORMAT_ZHEXADECIMAL>:
>>>>> New enum
>>>>>     field.
>>>>
>>>> I don't normally have authority to approve, but the patch looks
>>>> sufficiently mechanical that I think I can provide approval if
>>>> the area maintainer isn't available.
>> [...]
>>> I've updated the patch with your suggestions now.
>>
>> Thanks, Luis. FWIW, the patch looks good to me. Let's wait one more
>> week for the MI maintainer to give any feedback, but otherwise just
>> go ahead and push (based on the fact that it's fairly consistent with
>> what we already have, and a fairly mechanical change).
>>
>
> Thanks Joel. I'll push this one until the end of the week.
>
>

I've pushed this now.