From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119049 invoked by alias); 27 May 2015 10:16:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118864 invoked by uid 89); 27 May 2015 10:16:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 May 2015 10:16:44 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 79A1D8EA33; Wed, 27 May 2015 10:16:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4RAGacj019752; Wed, 27 May 2015 06:16:39 -0400 Message-ID: <55659984.90103@redhat.com> Date: Wed, 27 May 2015 10:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Max Filippov , gdb-patches@sourceware.org CC: Maxim Grigoriev , Woody LaRue , Marc Gauthier Subject: Re: [PATCH] xtensa: fix access to the last pseudo register References: <1431904329-13965-1-git-send-email-jcmvbkbc@gmail.com> In-Reply-To: <1431904329-13965-1-git-send-email-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00654.txt.bz2 On 05/18/2015 12:12 AM, Max Filippov wrote: > Currently access to the last pseudo register is aliased to a1. This is > done by little snippets in the beginning of xtensa_pseudo_register_read > and xtensa_pseudo_register_write that used to do such aliasing for FP > register since bdb4c075a29dd086f0868b394b488b1c94666be6, but then > FP_ALIAS was expanded into gdbarch_num_regs (current_gdbarch) + > gdbarch_num_pseudo_regs (current_gdbarch) (one register past the last > pseudo register) in 304fe2552d6e0821e8fdb7575f8e7ba6607a076d, which > then was changed to the last pseudo register in > 94a0e877111421d300d26b858bd3a0a27078d1e8. IIUC, the original intention was for FP to alias a1, and then through that series of patches (part of old current_gdbarch elimination) we ended up aliasing the wrong register. Instead of fixing the aliasing, you're just removing it altogether. Correct? OK. Thanks, Pedro Alves