public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
Date: Wed, 27 May 2015 15:54:00 -0000	[thread overview]
Message-ID: <5565E8BE.4060506@linux.vnet.ibm.com> (raw)
In-Reply-To: <86zj4qoyd3.fsf@gmail.com>

On 05/27/2015 12:04 PM, Yao Qi wrote:
> Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com> writes:
> 
>> unfortunately I was unable to apply your patch due to the follow:
>>
> 
> I copy my patch from thunderbird, and paste it in 2.path.  I have no
> trouble applying it.
> 
>> $ patch -p1 -i ~/fix.patch --dry
>> (Stripping trailing CRs from patch; use --binary to disable.)
>> checking file gdb/aarch64-tdep.c
>> patch: **** malformed patch at line 6: *aarch64_insn_r)
> 
> Does your editor split the line in patch like this?
> 
> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
> index 8597497..d07b26c 100644
> --- a/gdb/aarch64-tdep.c
> +++ b/gdb/aarch64-tdep.c
> @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record
> *aarch64_insn_r)
> ^^^^^^^^^^^^^^^
> 
> it should be in previous line.
> 

I also use thunderbird, but usually I save the raw message instead of
copying to avoid miscopies. But I managed to apply the patch after
copying it as you suggested and checked that it fixes the build issue.
Btw, I'm using gcc 4.8.3 for these tests.

Thanks!
--
Edjunior

  reply	other threads:[~2015-05-27 15:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 13:22 [PATCH 0/4 V6] Process record and reverse debugging support on aarch64-linux Yao Qi
2015-05-19 13:22 ` [PATCH 2/4] Implements aarch64 process record and reverse debugging support Yao Qi
2015-05-21 20:23   ` Pedro Alves
2015-05-26 11:41     ` Yao Qi
2015-05-26 20:00       ` Edjunior Barbosa Machado
2015-05-27  8:21         ` Yao Qi
2015-05-27  9:23           ` Yao Qi
2015-05-27 10:22           ` Yao Qi
2015-05-27 14:12             ` Edjunior Barbosa Machado
2015-05-27 15:05               ` Yao Qi
2015-05-27 15:54                 ` Edjunior Barbosa Machado [this message]
2015-05-27 16:18                   ` Yao Qi
2015-05-19 13:22 ` [PATCH 1/4] NEWS entry about aarch64-linux record/replay support Yao Qi
2015-05-19 13:23 ` [PATCH 4/4] New gdb.reverse test case for aarch64 instructions Yao Qi
2015-05-21 20:22   ` Pedro Alves
2015-05-26 11:26     ` Yao Qi
2015-05-19 13:23 ` [PATCH 3/4] Enables gdb.reverse testsuite for aarch64*-linux targets Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5565E8BE.4060506@linux.vnet.ibm.com \
    --to=emachado@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).