From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69369 invoked by alias); 27 May 2015 15:54:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69358 invoked by uid 89); 27 May 2015 15:54:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e24smtp05.br.ibm.com Received: from e24smtp05.br.ibm.com (HELO e24smtp05.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 27 May 2015 15:54:46 +0000 Received: from /spool/local by e24smtp05.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 May 2015 12:54:42 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp05.br.ibm.com (10.172.0.141) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 27 May 2015 12:54:41 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 7DD053520054 for ; Wed, 27 May 2015 11:53:37 -0400 (EDT) Received: from d24av04.br.ibm.com (d24av04.br.ibm.com [9.8.31.97]) by d24relay03.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4RFrYNq58523896 for ; Wed, 27 May 2015 12:53:34 -0300 Received: from d24av04.br.ibm.com (localhost [127.0.0.1]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4RFsdp6029304 for ; Wed, 27 May 2015 12:54:39 -0300 Received: from [9.8.6.171] ([9.8.6.171]) by d24av04.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t4RFsdFN029296; Wed, 27 May 2015 12:54:39 -0300 Message-ID: <5565E8BE.4060506@linux.vnet.ibm.com> Date: Wed, 27 May 2015 15:54:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support References: <1432041752-4638-1-git-send-email-yao.qi@linaro.org> <1432041752-4638-3-git-send-email-yao.qi@linaro.org> <555E3EAE.2080107@redhat.com> <86h9qzr2g2.fsf@gmail.com> <5564D0E9.3000402@linux.vnet.ibm.com> <86d21mqvl0.fsf@gmail.com> <868ucaqq0o.fsf@gmail.com> <5565D0B8.7090602@linux.vnet.ibm.com> <86zj4qoyd3.fsf@gmail.com> In-Reply-To: <86zj4qoyd3.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052715-0033-0000-0000-000002A13181 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00663.txt.bz2 On 05/27/2015 12:04 PM, Yao Qi wrote: > Edjunior Barbosa Machado writes: > >> unfortunately I was unable to apply your patch due to the follow: >> > > I copy my patch from thunderbird, and paste it in 2.path. I have no > trouble applying it. > >> $ patch -p1 -i ~/fix.patch --dry >> (Stripping trailing CRs from patch; use --binary to disable.) >> checking file gdb/aarch64-tdep.c >> patch: **** malformed patch at line 6: *aarch64_insn_r) > > Does your editor split the line in patch like this? > > diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c > index 8597497..d07b26c 100644 > --- a/gdb/aarch64-tdep.c > +++ b/gdb/aarch64-tdep.c > @@ -3592,7 +3592,7 @@ aarch64_record_data_proc_simd_fp (insn_decode_record > *aarch64_insn_r) > ^^^^^^^^^^^^^^^ > > it should be in previous line. > I also use thunderbird, but usually I save the raw message instead of copying to avoid miscopies. But I managed to apply the patch after copying it as you suggested and checked that it fixes the build issue. Btw, I'm using gcc 4.8.3 for these tests. Thanks! -- Edjunior