From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
Date: Fri, 29 May 2015 09:32:00 -0000 [thread overview]
Message-ID: <55683226.5050302@redhat.com> (raw)
In-Reply-To: <1432293831-23599-2-git-send-email-patrick@parcs.ath.cx>
On 05/22/2015 12:23 PM, Patrick Palka wrote:
> + while (isspace (*tmpenv))
> + tmpenv++;
...
> +
> + while (isspace (*endptr))
> + endptr++;
Use skip_spaces/skip_spaces_const for these.
Otherwise looks good to me.
(I suspect that testing the interaction between setting
the history both from a .gdbinit and $GDBHISTSIZE would
call for merging the gdbhistsize-history.exp / gdbinit-history.exp
to a single file.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-05-29 9:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 11:24 [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Patrick Palka
2015-05-22 11:24 ` [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999] Patrick Palka
2015-05-22 11:57 ` Patrick Palka
2015-05-29 9:32 ` Pedro Alves [this message]
2015-06-17 19:18 ` Patrick Palka
2015-06-23 12:56 ` Yao Qi
2015-06-23 14:28 ` Patrick Palka
2015-05-22 12:30 ` [PATCH 1/2] Read $GDBHISTSIZE instead of $HISTSIZE Eli Zaretskii
2015-06-04 15:30 ` Patrick Palka
2015-06-15 14:54 ` Pedro Alves
2015-05-29 11:05 ` Pedro Alves
2015-06-17 18:19 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55683226.5050302@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).