From: Pedro Alves <palves@redhat.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Fix MI dprintf-insert not printing on a resolved pending location.
Date: Fri, 12 Jun 2015 12:33:00 -0000 [thread overview]
Message-ID: <557AD190.9080104@redhat.com> (raw)
In-Reply-To: <1434112052-6972-1-git-send-email-antoine.tremblay@ericsson.com>
On 06/12/2015 01:27 PM, Antoine Tremblay wrote:
> ---
> Diffs in v3 :
> - some syntax formating for int main
> - wording changes to make it more clear that the pending location is now resolved
> - more explicit mi_expect_stop
Thanks. That does make it more obvious what is going on here.
> This patch fixes the "Format string required" error when trying to print
> a dprintf on a now resolved, pending location when set via the MI interface
> even if the format string is entered correctly.
>
> This patch also adds a test case to check that issue called
> mi-dprintf-pending.exp.
>
OK with:
> +extern void pendfunc ();
(void) here too.
Thank you and thanks Keith too.
--
Pedro Alves
next prev parent reply other threads:[~2015-06-12 12:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 16:47 [PATCH] Fix MI dprintf-insert not printing when a location is pending Antoine Tremblay
2015-03-26 19:11 ` Keith Seitz
2015-03-27 12:34 ` Antoine Tremblay
2015-03-27 12:37 ` Antoine Tremblay
2015-03-27 16:52 ` Keith Seitz
2015-03-27 17:13 ` Antoine Tremblay
2015-03-27 17:34 ` Keith Seitz
2015-04-20 12:14 ` Antoine Tremblay
2015-06-12 12:27 ` [PATCH v3] Fix MI dprintf-insert not printing on a resolved pending location Antoine Tremblay
2015-06-12 12:33 ` Pedro Alves [this message]
2015-03-27 16:46 ` [PATCH] Fix MI dprintf-insert not printing when a location is pending Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557AD190.9080104@redhat.com \
--to=palves@redhat.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).