From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51612 invoked by alias); 17 Jun 2015 12:46:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51149 invoked by uid 89); 17 Jun 2015 12:46:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Jun 2015 12:46:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id D1B94C131B; Wed, 17 Jun 2015 12:46:46 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5HCkiIt016453; Wed, 17 Jun 2015 08:46:45 -0400 Message-ID: <55816C34.3060908@redhat.com> Date: Wed, 17 Jun 2015 12:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't truncate the history file when history size is unlimited References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00360.txt.bz2 On 06/16/2015 03:53 PM, Patrick Palka wrote: > + # We have to start then exit GDB twice: the first time to test the creation > + # of the initial history file, and the second time to test appending to it. > + # In either case the initial "print 1" command should persist through the > + # history file. > + with_test_prefix "truncation" { > + gdb_exit > + gdb_start > + gdb_test "print 1" > + > + gdb_exit > + gdb_start > + gdb_test "server show commands" " . print 1.*" > + > + gdb_exit > + gdb_start > + gdb_test "server show commands" " . print 1.*" These two "show commands" tests have the same output message. The patch is OK with that fixed. Thanks for following through with the test. Thanks, Pedro Alves