From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105329 invoked by alias); 17 Jun 2015 13:14:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105318 invoked by uid 89); 17 Jun 2015 13:14:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Jun 2015 13:14:41 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 719C3C9444; Wed, 17 Jun 2015 13:14:40 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5HDEcVJ005652; Wed, 17 Jun 2015 09:14:39 -0400 Message-ID: <558172BE.7000602@redhat.com> Date: Wed, 17 Jun 2015 13:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Don't truncate the history file when history size is unlimited References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00361.txt.bz2 On 06/16/2015 04:00 PM, Patrick Palka wrote: > By the way, what do you think about unsetting > HOME/HISTSIZE/GDBHISTFILE somewhere higher up in the testsuite > infrastructure? It would be nice if individual tests did not have to > worry about such environment variables being leaked from userspace. On first blush, that sounds like a good idea. Though I wonder whether that could have unintended consequences. We won't know until we try, I guess. Does dejagnu need HOME set? Does Python/Scheme? Unsetting the GDB-specific GDBHISTSIZE/GDBHISTFILE vars sounds like a no brainer. For HISTSIZE, should we audit tests that might start an interactive shell (e.g., "(gdb) shell") and result in truncating the history file? Guess better would be to set HISTSIZE="" and HISTFILE=/dev/null or something like that so shells we start don't have a chance of mucking with the user's history files? Urgh, yes, we already have that issue today: $ make check RUNTESTFLAGS="gdb.base/batch-preserve-term-settings.exp" $ tail -n 5 ~/.bash_history stty || echo "not found" /home/pedro/gdb/mygit/build/gdb/testsuite/../../gdb/gdb -nw -nx -data-directory /home/pedro/gdb/mygit/build/gdb/testsuite/../data-directory -batch -ex "set height unlimited" -ex "start" --args "/home/pedro/gdb/mygit/build/gdb/testsuite/gdb.base/batch-preserve-term-settings" echo test_echo stty || echo "not found" exit Whoops... Thanks, Pedro Alves