From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40367 invoked by alias); 17 Jun 2015 13:43:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40340 invoked by uid 89); 17 Jun 2015 13:43:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Jun 2015 13:43:42 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 525C62D1558; Wed, 17 Jun 2015 13:43:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5HDhdFo011930; Wed, 17 Jun 2015 09:43:40 -0400 Message-ID: <5581798B.5080207@redhat.com> Date: Wed, 17 Jun 2015 13:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix problems with finishing a dummy function call on simulators. References: <1433862056-18237-1-git-send-email-lgustavo@codesourcery.com> <55772797.802@redhat.com> <55805F52.20805@codesourcery.com> <55816AD5.6020605@redhat.com> <55817569.7060704@codesourcery.com> In-Reply-To: <55817569.7060704@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00363.txt.bz2 On 06/17/2015 02:26 PM, Luis Machado wrote: > On 06/17/2015 09:40 AM, Pedro Alves wrote: >> Yep. Close, but also remove the bp_call_dummy check in >> bp_loc_is_permanent, and merge in its comment, like ... >> > > Fixed now. Looks good now. Thanks. > The attached updated patch also removes this dead function. I can commit > it as a separate patch if you're not removing it yourself. Nah, I was hoping you'd remove it. :-) Please also remove the make_breakpoint_permanent declaration from breakpoint.h though. Thanks, Pedro Alves