From: Jon TURNEY <jon.turney@dronecode.org.uk>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also
Date: Thu, 18 Jun 2015 11:05:00 -0000 [thread overview]
Message-ID: <5582A5F3.1060602@dronecode.org.uk> (raw)
In-Reply-To: <86k2v2s4f4.fsf@gmail.com>
On 17/06/2015 17:09, Yao Qi wrote:
> Jon Turney writes:
>
>> + return $data
>> }
>> - set fi [open $tmp]
>> - fconfigure $fi -translation binary
>> - # Skip the NOTE header.
>> - read $fi 16
>> - set data [read $fi]
>> - close $fi
>> - file delete $tmp
>> - if ![string compare $data ""] then {
>> - return ""
>> + else
>> + {
>
> braces and "else" are put in the different lines. It causes the tcl
> error,
>
> Running ../../../binutils-gdb/gdb/testsuite/gdb.base/break-interp.exp ...
> ERROR: (DejaGnu) proc "else" does not exist.
> The error code is NONE
> The info on the error is:
> invalid command name "else"
> while executing
> "::tcl_unknown else"
> ("uplevel" body line 1)
> invoked from within
> "uplevel 1 ::tcl_unknown $args"
>
> Patch below fixes this error. I'll push it in.
Thanks.
prev parent reply other threads:[~2015-06-18 11:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 15:37 [PATCH] Find debug symbols file by buildid for coff " Jon TURNEY
2015-03-16 16:30 ` Eli Zaretskii
2015-03-17 12:56 ` Jon TURNEY
2015-04-08 12:17 ` [PATCH] Find debug symbols file by buildid for PE " Jon TURNEY
2015-04-08 12:39 ` Eli Zaretskii
2015-04-22 13:41 ` Jon TURNEY
2015-06-02 13:33 ` Jon TURNEY
2015-06-09 19:36 ` Joel Brobecker
2015-06-10 14:26 ` [PATCH] Allow gdb to find debug symbols file by build-id " Jon Turney
2015-06-12 15:45 ` Nicholas Clifton
2015-06-15 16:34 ` Mike Frysinger
2015-06-15 18:13 ` Andreas Schwab
2015-06-15 18:25 ` Jon TURNEY
2015-06-16 11:35 ` Nicholas Clifton
2015-06-17 16:09 ` Yao Qi
2015-06-18 11:05 ` Jon TURNEY [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5582A5F3.1060602@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).