From: Michael Eager <eager@eagerm.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: microblaze: delete useless stubs
Date: Mon, 22 Jun 2015 14:28:00 -0000 [thread overview]
Message-ID: <55881B5E.3020808@eagerm.com> (raw)
In-Reply-To: <20150622045610.GE17734@vapier>
On 06/21/2015 09:56 PM, Mike Frysinger wrote:
> On 21 Jun 2015 12:36, Michael Eager wrote:
>> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
>>> These don't accomplish anything the common core doesn't already, so
>>> punt them as they purely waste code.
>>>
>>> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>>>
>>> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
>>> (microblaze_push_dummy_call): Likewise.
>>> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
>>> and set_gdbarch_push_dummy_call.
>>
>> Does the common code issue an error if someone tries
>> to call a target function?
>
> yes
>
> gdb/infcall.c:
> struct value *
> call_function_by_hand_dummy (struct value *function,
> ...
> if (!gdbarch_push_dummy_call_p (gdbarch))
> error (_("This target does not support function calls."));
>
> $ ./gdb ...
> (gdb) p foo(1)
> This target does not support function calls.
> -mike
Go ahead and commit.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2015-06-22 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 18:13 Mike Frysinger
2015-06-21 19:36 ` Michael Eager
2015-06-22 4:56 ` Mike Frysinger
2015-06-22 14:28 ` Michael Eager [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-21 18:08 [PATCH] gdb: sim: handle target sysroot prefix Mike Frysinger
2015-06-23 15:29 ` [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
2015-06-23 15:31 ` Mike Frysinger
2015-06-23 17:39 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55881B5E.3020808@eagerm.com \
--to=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).