* [PATCH] gdb: microblaze: delete useless stubs
@ 2015-06-21 18:13 Mike Frysinger
2015-06-21 19:36 ` Michael Eager
0 siblings, 1 reply; 7+ messages in thread
From: Mike Frysinger @ 2015-06-21 18:13 UTC (permalink / raw)
To: gdb-patches; +Cc: eager
These don't accomplish anything the common core doesn't already, so
punt them as they purely waste code.
2015-06-21 Mike Frysinger <vapier@gentoo.org>
* microblaze-tdep.c (microblaze_push_dummy_code): Delete.
(microblaze_push_dummy_call): Likewise.
(microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
and set_gdbarch_push_dummy_call.
---
gdb/microblaze-tdep.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c
index d66914e..8cc1df2 100644
--- a/gdb/microblaze-tdep.c
+++ b/gdb/microblaze-tdep.c
@@ -134,30 +134,6 @@ microblaze_fetch_instruction (CORE_ADDR pc)
return extract_unsigned_integer (buf, 4, byte_order);
}
\f
-
-static CORE_ADDR
-microblaze_push_dummy_code (struct gdbarch *gdbarch, CORE_ADDR sp,
- CORE_ADDR funcaddr,
- struct value **args, int nargs,
- struct type *value_type,
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
- struct regcache *regcache)
-{
- error (_("push_dummy_code not implemented"));
- return sp;
-}
-
-
-static CORE_ADDR
-microblaze_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
- struct regcache *regcache, CORE_ADDR bp_addr,
- int nargs, struct value **args, CORE_ADDR sp,
- int struct_return, CORE_ADDR struct_addr)
-{
- error (_("store_arguments not implemented"));
- return sp;
-}
-
static const gdb_byte *
microblaze_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pc,
int *len)
@@ -749,8 +725,6 @@ microblaze_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* Call dummy code. */
set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
- set_gdbarch_push_dummy_code (gdbarch, microblaze_push_dummy_code);
- set_gdbarch_push_dummy_call (gdbarch, microblaze_push_dummy_call);
set_gdbarch_return_value (gdbarch, microblaze_return_value);
set_gdbarch_stabs_argument_has_addr
--
2.4.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gdb: microblaze: delete useless stubs
2015-06-21 18:13 [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
@ 2015-06-21 19:36 ` Michael Eager
2015-06-22 4:56 ` Mike Frysinger
0 siblings, 1 reply; 7+ messages in thread
From: Michael Eager @ 2015-06-21 19:36 UTC (permalink / raw)
To: Mike Frysinger, gdb-patches
On 06/21/2015 11:13 AM, Mike Frysinger wrote:
> These don't accomplish anything the common core doesn't already, so
> punt them as they purely waste code.
>
> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>
> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> (microblaze_push_dummy_call): Likewise.
> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> and set_gdbarch_push_dummy_call.
Does the common code issue an error if someone tries
to call a target function?
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gdb: microblaze: delete useless stubs
2015-06-21 19:36 ` Michael Eager
@ 2015-06-22 4:56 ` Mike Frysinger
2015-06-22 14:28 ` Michael Eager
0 siblings, 1 reply; 7+ messages in thread
From: Mike Frysinger @ 2015-06-22 4:56 UTC (permalink / raw)
To: Michael Eager; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
On 21 Jun 2015 12:36, Michael Eager wrote:
> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
> > These don't accomplish anything the common core doesn't already, so
> > punt them as they purely waste code.
> >
> > 2015-06-21 Mike Frysinger <vapier@gentoo.org>
> >
> > * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> > (microblaze_push_dummy_call): Likewise.
> > (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> > and set_gdbarch_push_dummy_call.
>
> Does the common code issue an error if someone tries
> to call a target function?
yes
gdb/infcall.c:
struct value *
call_function_by_hand_dummy (struct value *function,
...
if (!gdbarch_push_dummy_call_p (gdbarch))
error (_("This target does not support function calls."));
$ ./gdb ...
(gdb) p foo(1)
This target does not support function calls.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gdb: microblaze: delete useless stubs
2015-06-22 4:56 ` Mike Frysinger
@ 2015-06-22 14:28 ` Michael Eager
0 siblings, 0 replies; 7+ messages in thread
From: Michael Eager @ 2015-06-22 14:28 UTC (permalink / raw)
To: gdb-patches
On 06/21/2015 09:56 PM, Mike Frysinger wrote:
> On 21 Jun 2015 12:36, Michael Eager wrote:
>> On 06/21/2015 11:13 AM, Mike Frysinger wrote:
>>> These don't accomplish anything the common core doesn't already, so
>>> punt them as they purely waste code.
>>>
>>> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>>>
>>> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
>>> (microblaze_push_dummy_call): Likewise.
>>> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
>>> and set_gdbarch_push_dummy_call.
>>
>> Does the common code issue an error if someone tries
>> to call a target function?
>
> yes
>
> gdb/infcall.c:
> struct value *
> call_function_by_hand_dummy (struct value *function,
> ...
> if (!gdbarch_push_dummy_call_p (gdbarch))
> error (_("This target does not support function calls."));
>
> $ ./gdb ...
> (gdb) p foo(1)
> This target does not support function calls.
> -mike
Go ahead and commit.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gdb: microblaze: delete useless stubs
2015-06-23 15:29 ` [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
2015-06-23 15:31 ` Mike Frysinger
@ 2015-06-23 17:39 ` Michael Eager
1 sibling, 0 replies; 7+ messages in thread
From: Michael Eager @ 2015-06-23 17:39 UTC (permalink / raw)
To: Mike Frysinger, gdb-patches; +Cc: gbenson
On 06/23/2015 08:29 AM, Mike Frysinger wrote:
> These don't accomplish anything the common core doesn't already, so
> punt them as they purely waste code.
>
> 2015-06-21 Mike Frysinger <vapier@gentoo.org>
>
> * microblaze-tdep.c (microblaze_push_dummy_code): Delete.
> (microblaze_push_dummy_call): Likewise.
> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
> and set_gdbarch_push_dummy_call.
> ---
> gdb/microblaze-tdep.c | 26 --------------------------
> 1 file changed, 26 deletions(-)
OK.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gdb: microblaze: delete useless stubs
2015-06-23 15:29 ` [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
@ 2015-06-23 15:31 ` Mike Frysinger
2015-06-23 17:39 ` Michael Eager
1 sibling, 0 replies; 7+ messages in thread
From: Mike Frysinger @ 2015-06-23 15:31 UTC (permalink / raw)
To: gdb-patches; +Cc: gbenson
[-- Attachment #1: Type: text/plain, Size: 67 bytes --]
sorry, ignore this patch. had a stale local one in my tree.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] gdb: microblaze: delete useless stubs
2015-06-21 18:08 [PATCH] gdb: sim: handle target sysroot prefix Mike Frysinger
@ 2015-06-23 15:29 ` Mike Frysinger
2015-06-23 15:31 ` Mike Frysinger
2015-06-23 17:39 ` Michael Eager
0 siblings, 2 replies; 7+ messages in thread
From: Mike Frysinger @ 2015-06-23 15:29 UTC (permalink / raw)
To: gdb-patches; +Cc: gbenson
These don't accomplish anything the common core doesn't already, so
punt them as they purely waste code.
2015-06-21 Mike Frysinger <vapier@gentoo.org>
* microblaze-tdep.c (microblaze_push_dummy_code): Delete.
(microblaze_push_dummy_call): Likewise.
(microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code
and set_gdbarch_push_dummy_call.
---
gdb/microblaze-tdep.c | 26 --------------------------
1 file changed, 26 deletions(-)
diff --git a/gdb/microblaze-tdep.c b/gdb/microblaze-tdep.c
index d66914e..8cc1df2 100644
--- a/gdb/microblaze-tdep.c
+++ b/gdb/microblaze-tdep.c
@@ -134,30 +134,6 @@ microblaze_fetch_instruction (CORE_ADDR pc)
return extract_unsigned_integer (buf, 4, byte_order);
}
\f
-
-static CORE_ADDR
-microblaze_push_dummy_code (struct gdbarch *gdbarch, CORE_ADDR sp,
- CORE_ADDR funcaddr,
- struct value **args, int nargs,
- struct type *value_type,
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr,
- struct regcache *regcache)
-{
- error (_("push_dummy_code not implemented"));
- return sp;
-}
-
-
-static CORE_ADDR
-microblaze_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
- struct regcache *regcache, CORE_ADDR bp_addr,
- int nargs, struct value **args, CORE_ADDR sp,
- int struct_return, CORE_ADDR struct_addr)
-{
- error (_("store_arguments not implemented"));
- return sp;
-}
-
static const gdb_byte *
microblaze_breakpoint_from_pc (struct gdbarch *gdbarch, CORE_ADDR *pc,
int *len)
@@ -749,8 +725,6 @@ microblaze_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
/* Call dummy code. */
set_gdbarch_call_dummy_location (gdbarch, ON_STACK);
- set_gdbarch_push_dummy_code (gdbarch, microblaze_push_dummy_code);
- set_gdbarch_push_dummy_call (gdbarch, microblaze_push_dummy_call);
set_gdbarch_return_value (gdbarch, microblaze_return_value);
set_gdbarch_stabs_argument_has_addr
--
2.4.1
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-23 17:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-21 18:13 [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
2015-06-21 19:36 ` Michael Eager
2015-06-22 4:56 ` Mike Frysinger
2015-06-22 14:28 ` Michael Eager
-- strict thread matches above, loose matches on Subject: below --
2015-06-21 18:08 [PATCH] gdb: sim: handle target sysroot prefix Mike Frysinger
2015-06-23 15:29 ` [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
2015-06-23 15:31 ` Mike Frysinger
2015-06-23 17:39 ` Michael Eager
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).