From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91782 invoked by alias); 30 Jun 2015 09:36:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91765 invoked by uid 89); 30 Jun 2015 09:36:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 09:36:32 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id ADB058E76C; Tue, 30 Jun 2015 09:36:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5U9aTsc019675; Tue, 30 Jun 2015 05:36:30 -0400 Message-ID: <5592631D.4020108@redhat.com> Date: Tue, 30 Jun 2015 09:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use gdbarch obstack to allocate the TYPE_NAME string in arch_type References: <1435631281-31970-1-git-send-email-patrick@parcs.ath.cx> <1435631281-31970-2-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435631281-31970-2-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00622.txt.bz2 On 06/30/2015 03:28 AM, Patrick Palka wrote: > Since the type whose name is being set is now being allocated on the > gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. > This reduces the number of individual valgrind warnings for the command > "gdb gdb" from ~300 to ~150. > > Tested on x86_64-unknown-linux-gnu. > > [ I have a few more patches on top of these that together bring the total > number of valgrind warnings for the command "gdb gdb" down to ~30 > but they are more controversial than these two, and if these aren't OK > then the rest definitely aren't OK. ] Both patches look fine to me. If this blows up for some reason, I guess we'll take the opportunity to add a comment explaining why these must go on the heap. :-) Thanks, Pedro Alves