From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71655 invoked by alias); 30 Jun 2015 09:57:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71590 invoked by uid 89); 30 Jun 2015 09:57:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 09:57:41 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id D9BBB357E9B; Tue, 30 Jun 2015 09:57:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5U9vbGN008462; Tue, 30 Jun 2015 05:57:38 -0400 Message-ID: <55926811.6020505@redhat.com> Date: Tue, 30 Jun 2015 09:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Wei-cheng Wang , uweigand@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [PATCH 3/5 v4] Fix argument to compiled_cond, and add cases for compiled-condition. References: <1435422102-39438-1-git-send-email-cole945@gmail.com> <1435422102-39438-3-git-send-email-cole945@gmail.com> In-Reply-To: <1435422102-39438-3-git-send-email-cole945@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00624.txt.bz2 On 06/27/2015 05:21 PM, Wei-cheng Wang wrote: > Hi, > > Ulrich Weigand wrote: >> > Ah, when I said to add new test cases in a separate patch, what I meant was: >> > - use a separate patch (applied *first*) that adds the *new tests* (to be >> > run on existing platforms), i.e. test_ftrace_condition >> > - as part of the patch that actually adds powerpc support, add all the small >> > test case snippets that specifically enable the test cases for powerpc >> > This is again so that each set in a series is meaningful in itself (and >> > does not introduce testsuite regressions when applied alone). > ... >> > Wei-cheng Wang wrote: >>> > >if (tpoint->compiled_cond) >>> > > err = ((condfn) (uintptr_t) (tpoint->compiled_cond)) (ctx, &value); >>> > > >>> > >I think probably either we could pass ctx->regs to compiled_cond instead, >>> > >or move the declarations of fast_tracepoint_ctx (and others) to tracepoint.h, >>> > >so we can use "offsetof (fast_tracepoint_ctx, regs)" instead. >>> > >Any suggestion? >> > FWIW, passing the regs buffer directly to the compiled routine seems >> > more straightforward to me ... > Some of the new cases are used to testing emit-reg, and emit-reg for x86 > doesn't work due to the incorrect argument to compiled_cond - "regs" buffer > is expected, but tracepoint context is passed > > This case also includes the fix for complied_cond in order for x86 to > pass testing for emit-reg op. > > Testing result on my x86_64 Ubuntu 14.04.2 TLS > > before w/ new cases only w/ the fix > PASS 2625 2759 2765 > FAIL 33 39 33 > XFAIL 16 16 16 > KFAIL 2 2 2 > UNTESTED 1 1 1 > UNSUPPORTED 3 3 3 > > Thanks, > Wei-cheng > > --- > > * Fix generating emit-reg op by passing register buffer to compiled_cond. > * Add a new function for testing compiled-cond by checking whether > based on a given CONDEXP, a list of expected values should be collected. > > --- FWIW, looks good to me too. Thanks for the new tests! Thanks, Pedro Alves