From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123897-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 46987 invoked by alias); 30 Jun 2015 12:57:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 46953 invoked by uid 89); 30 Jun 2015 12:57:07 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 12:57:05 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 43B0F19F23B;	Tue, 30 Jun 2015 12:57:04 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UCv2gN026352;	Tue, 30 Jun 2015 08:57:03 -0400
Message-ID: <5592921E.4060009@redhat.com>
Date: Tue, 30 Jun 2015 12:57:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH 5/5] btrace: maintenance commands
References: <1435047418-21611-1-git-send-email-markus.t.metzger@intel.com> <1435047418-21611-6-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1435047418-21611-6-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-06/txt/msg00632.txt.bz2

On 06/23/2015 09:16 AM, Markus Metzger wrote:
> Add maintenance commands that help debugging the btrace record target.
> The following new commands are added:

Looks good to me, with the minor nits pointed out below addressed.


>  }
> @@ -2192,3 +2235,682 @@ make_cleanup_btrace_data (struct btrace_data *data)
>  {
>    return make_cleanup (do_btrace_data_cleanup, data);
>  }
> +
> +#if defined (HAVE_LIBIPT)
> +
> +/* Print a single packet.  */
> +
> +static void
> +pt_print_packet (const struct pt_packet *packet)
> +{
> +  switch (packet->type)
> +    {
> +    default:
> +      printf_unfiltered ("[??: %x]", packet->type);

I think the missing _() will result in ARI warnings.
You can use extra ()'s to suppress them, like:

     printf_unfiltered (("[??: %x]"), packet->type);


> +      break;
> +
> +    case ppt_psb:
> +      printf_unfiltered ("psb");
> +      break;

etc.

> +btrace clear-packet-history' to clear and recompute the existing history."),
> +			   NULL, NULL, &maint_btrace_pt_set_cmdlist,
> +			   &maint_btrace_pt_show_cmdlist);

Please add a show callback.

Thanks,
Pedro Alves