From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15397 invoked by alias); 30 Jun 2015 16:55:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15388 invoked by uid 89); 30 Jun 2015 16:55:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 16:55:05 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 8F4CE9247D; Tue, 30 Jun 2015 16:55:04 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UGt2XN015476; Tue, 30 Jun 2015 12:55:03 -0400 Message-ID: <5592C9E6.5040202@redhat.com> Date: Tue, 30 Jun 2015 16:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan-Benedict Glaw , Iain Buclaw CC: gdb-patches@sourceware.org, yunlian@google.com Subject: Re: [BUILDROBOT] asprintf() no longer declared References: <20150625142348.GO16812@lug-owl.de> <20150630162540.GA23299@lug-owl.de> In-Reply-To: <20150630162540.GA23299@lug-owl.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00654.txt.bz2 On 06/30/2015 05:25 PM, Jan-Benedict Glaw wrote: > On Thu, 2015-06-25 16:23:48 +0200, Jan-Benedict Glaw wrote: >> On Fri, 2015-06-19 17:18:38 +0200, Iain Buclaw wrote: >>> Belated attempt at downstreaming libiberty changes from upstream. >>> Split it into two patches, one with dlang related changes, the other >>> with everything else. >>> >>> As requested, commits have been replayed ontop of gdb rather than a >>> straight diff between the directories. >> [...] >> >> Seems there were some minor changes in libiberty which breaks code >> generation on non-GNU systems due to missing asprintf(). >> >> On the AIX builder (gcc111.fsffrance.org), I see build failures in >> Binutils since then, see ie. >> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=448549: >> >> /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/home/jbglaw/repos/binutils_gdb/bfd -I. -I/home/jbglaw/repos/binutils_gdb/bfd -I/home/jbglaw/repos/binutils_gdb/bfd/../include -DHAVE_cr16_elf32_vec -DHAVE_elf32_le_vec -DHAVE_elf32_be_vec -DHAVE_plugin_vec -DBINDIR='"/home/jbglaw/build/cr16-elf/_install_/bin"' -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -I/home/jbglaw/repos/binutils_gdb/bfd/../zlib -g -O2 -MT bfd.lo -MD -MP -MF .deps/bfd.Tpo -c -o bfd.lo /home/jbglaw/repos/binutils_gdb/bfd/bfd.c >> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/home/jbglaw/repos/binutils_gdb/bfd -I. -I/home/jbglaw/repos/binutils_gdb/bfd -I/home/jbglaw/repos/binutils_gdb/bfd/../include -DHAVE_cr16_elf32_vec -DHAVE_elf32_le_vec -DHAVE_elf32_be_vec -DHAVE_plugin_vec -DBINDIR=\"/home/jbglaw/build/cr16-elf/_install_/bin\" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -I/home/jbglaw/repos/binutils_gdb/bfd/../zlib -g -O2 -MT bfd.lo -MD -MP -MF .deps/bfd.Tpo -c /home/jbglaw/repos/binutils_gdb/bfd/bfd.c -o bfd.o >> /home/jbglaw/repos/binutils_gdb/bfd/bfd.c: In function 'bfd_errmsg': >> /home/jbglaw/repos/binutils_gdb/bfd/bfd.c:543:7: error: implicit declaration of function 'asprintf' [-Werror=implicit-function-declaration] >> if (asprintf (&buf, _(bfd_errmsgs [error_tag]), input_bfd->filename, msg) >> ^ >> cc1: all warnings being treated as errors >> make[3]: *** [bfd.lo] Error 1 >> make[3]: Leaving directory `/home/jbglaw/build/cr16-elf/build-binutils-full/bfd' > > It's a few days since building GDB probably broke on all non-GNU > platforms. Is somebody about to work on that? TBC, this is not really Iain's fault, as his patch was just a merge from upstream. (It'd be good if people interested in the affected platforms came forward and help diagnose/fix it.) I suspect that this is what is breaking things: --- a/include/ChangeLog +++ b/include/ChangeLog +2015-05-22 Yunlian Jiang + + * libiberty.h (asprintf): Don't declare if HAVE_DECL_ASPRINTF is + not defined. + I see here that Yunlian actually wanted this to fix the gdb build: https://sourceware.org/ml/gdb-patches/2015-05/msg00665.html Iain just happened to merge the patch sooner. Added Yunlian Jiang to CC. I think the problem is that bfd's configure.ac is missing an AC_CHECK_DECLS for asprintf, so that HAVE_DECL_ASPRINTF can end up defined. (the series mentioned at https://gcc.gnu.org/ml/gcc-patches/2015-02/msg01712.html would address this for good all over the tree, but I never heard from the libiberty maintainers about that idea. Surprisingly, I notice now that I missed converting bfd/.) Thanks, Pedro Alves