From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22435 invoked by alias); 1 Jul 2015 14:19:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22345 invoked by uid 89); 1 Jul 2015 14:19:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f170.google.com Received: from mail-pd0-f170.google.com (HELO mail-pd0-f170.google.com) (209.85.192.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 01 Jul 2015 14:19:07 +0000 Received: by pdbep18 with SMTP id ep18so26661236pdb.1 for ; Wed, 01 Jul 2015 07:19:05 -0700 (PDT) X-Received: by 10.70.50.199 with SMTP id e7mr56074331pdo.124.1435760345240; Wed, 01 Jul 2015 07:19:05 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id bf5sm2485597pad.43.2015.07.01.07.19.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Jul 2015 07:19:04 -0700 (PDT) Message-ID: <5593F6D5.5060703@gmail.com> Date: Wed, 01 Jul 2015 14:19:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andreas Schwab CC: gdb-patches@sourceware.org Subject: Re: [PATCH 08/11] New proc is_aarch64_target References: <1435759111-22856-1-git-send-email-yao.qi@linaro.org> <1435759111-22856-9-git-send-email-yao.qi@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00046.txt.bz2 On 01/07/15 15:10, Andreas Schwab wrote: >> + return [expr ![is_aarch32_target]] > [expr] is redundant. If I write "return ![is_aarch32_target]", I'll get a tcl error, ERROR: tcl error sourcing ../../../binutils-gdb/gdb/testsuite/gdb.arch/aarch64-atomic-inst.exp. ERROR: expected boolean value but got "!1" while executing "if {![is_aarch64_target]} { verbose "Skipping ${gdb_test_file_name}." return }" -- Yao (齐尧)