From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114073 invoked by alias); 1 Jul 2015 15:55:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113170 invoked by uid 89); 1 Jul 2015 15:55:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jul 2015 15:55:14 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B8D68365055; Wed, 1 Jul 2015 15:55:13 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t61FtCgv011018; Wed, 1 Jul 2015 11:55:12 -0400 Message-ID: <55940D5F.7020801@redhat.com> Date: Wed, 01 Jul 2015 15:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Make sure to update registers if frame information has changed References: <1435754216-31399-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435754216-31399-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00053.txt.bz2 On 07/01/2015 01:36 PM, Patrick Palka wrote: > When I removed TUI's frame_changed hook to fix PR tui/13378 I assumed > that there's no reason to refresh register information following a call > to "up", "down" or "frame". This assumption was made to fix the problem > of refreshing frame information twice following a sync-execution normal > stop (once in tui_normal_stop and then in tui_before_prompt) -- the > second refresh removing any highlights made by the first. Whoops, sorry, should have noticed that myself too. Patch is OK. Thanks for the quick fixing. Thanks, Pedro Alves