public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Nicholas Clifton <nickc@redhat.com>
To: Andre Vieira <Andre.SimoesDiasVieira@arm.com>, vapier@gentoo.org
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: AArch64 sim
Date: Thu, 02 Jul 2015 13:53:00 -0000	[thread overview]
Message-ID: <55954270.5090803@redhat.com> (raw)
In-Reply-To: <559501B1.6090801@arm.com>

Hi Andre,

> I realize EXTRA_SIM_CFLAGS with "-lm" is in there to deal with the use
> of math lib. Though I think EXTRA_SIM_CFLAGS is being expanded too early
> in the compile command, i.e. before libsim.a is passed on. Shouldn't it
> be put after libsim.a? As it could potentially cause a linker failure.

You are right, although strangely it still works for me...

Anyway, please could you test out the patch below.  If it works for you 
then I will check it in.

Cheers
   Nick

diff --git a/sim/arm/Makefile.in b/sim/arm/Makefile.in
index 7605588..1eeec25 100644
--- a/sim/arm/Makefile.in
+++ b/sim/arm/Makefile.in
@@ -17,7 +17,8 @@

  ## COMMON_PRE_CONFIG_FRAG

-SIM_EXTRA_CFLAGS = -DMODET -lm
+SIM_EXTRA_CFLAGS = -DMODET
+SIM_EXTRA_LIBS = -lm

  SIM_OBJS = \
         wrapper.o \

  reply	other threads:[~2015-07-02 13:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-28 12:25 Nick Clifton
2015-07-02  9:17 ` Andre Vieira
2015-07-02 13:53   ` Nicholas Clifton [this message]
2015-07-02 14:43     ` Andre Vieira
     [not found]     ` <55954DEE.50609@arm.com>
2015-07-02 15:20       ` Nicholas Clifton
2015-07-07 17:12 ` Mike Frysinger
2015-07-15 16:58 ` Nick Clifton
2015-07-16 15:19   ` Mike Frysinger
2015-07-17 14:10     ` Nicholas Clifton
2015-11-10  7:32       ` Mike Frysinger
2015-11-19 14:51         ` Nick Clifton
2015-11-20  9:13           ` Mike Frysinger
2015-11-20 10:56             ` Nick Clifton
2015-11-20 19:28               ` Mike Frysinger
2015-11-24  8:50                 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55954270.5090803@redhat.com \
    --to=nickc@redhat.com \
    --cc=Andre.SimoesDiasVieira@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).