From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122999 invoked by alias); 3 Jul 2015 18:24:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122968 invoked by uid 89); 3 Jul 2015 18:24:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 03 Jul 2015 18:24:38 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 08B3436B38C; Fri, 3 Jul 2015 18:24:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t63IOZxY010956; Fri, 3 Jul 2015 14:24:36 -0400 Message-ID: <5596D363.7040806@redhat.com> Date: Fri, 03 Jul 2015 18:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Cleanup value_fetch_lazy's comment and return value References: <1435946662-31310-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1435946662-31310-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00104.txt.bz2 On 07/03/2015 07:04 PM, Simon Marchi wrote: > The comment for value_fetch_lazy seems outdated. It says that it's only > called from the value_contents and value_contents_all (macros!), which > is not true. Also, the return value seems useless now, despite what the > comment says. OK. Thanks, Pedro Alves