From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12098 invoked by alias); 8 Jul 2015 10:57:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12084 invoked by uid 89); 8 Jul 2015 10:57:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 10:57:03 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6DBAB376B99; Wed, 8 Jul 2015 10:57:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68Av00F003202; Wed, 8 Jul 2015 06:57:01 -0400 Message-ID: <559D01FC.5000804@redhat.com> Date: Wed, 08 Jul 2015 10:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Pierre Langlois , gdb-patches@sourceware.org Subject: Re: [PATCH 0/8] [AArch64] Add support for tracepoints References: <1436273518-5959-1-git-send-email-pierre.langlois@arm.com> In-Reply-To: <1436273518-5959-1-git-send-email-pierre.langlois@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00199.txt.bz2 On 07/07/2015 01:51 PM, Pierre Langlois wrote: > Hi all, > > These patches enable tracepoints for AArch64. Although tracepoints are > enabled in GDBServer with the last patch, most of the changes are in GDB. > The most important changes teach AArch64's frame unwinders to report when > the inferior is unavailable. > > The first three patches refactor the frame caches. The idea is to keep > accesses to the inferior's registers in aarch64_make_prologue_cache and > aarch64_make_stub_cache. This way the following patches can easily catch > exceptions when the inferior is unavailable. > > The following two patches teach AArch64's unwinders to terminate > gracefully, in a similar way as it was done for x86 here: > > https://sourceware.org/ml/gdb-patches/2011-02/msg00611.html > > It fixes cases where we do not have debugging information and AArch64's > unwinders need to be used when examining a trace buffer. In this context > we cannot assume that the inferior's memory and registers are available. > This all looks like what I'd expect to see. LGTM. Yao may want to take a look too. Just a few nits: - In a few patches, you had a spurious empty line in the middle of the ChangeLog entry. Remove it please. - Several new functions are missing an intro comment. - aarch64_prologue_frame_unwind_stop_reason in patch 4 has odd indentation in the "We've hit a wall" case. Thanks, Pedro Alves