From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113340 invoked by alias); 8 Jul 2015 13:42:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113325 invoked by uid 89); 8 Jul 2015 13:42:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 13:41:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 8359736B1B6; Wed, 8 Jul 2015 13:41:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68DfvTK009289; Wed, 8 Jul 2015 09:41:57 -0400 Message-ID: <559D28A4.3040402@redhat.com> Date: Wed, 08 Jul 2015 13:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] record: set stop_pc in "record goto" command References: <1436360074-8625-1-git-send-email-markus.t.metzger@intel.com> <1436360074-8625-2-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1436360074-8625-2-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00211.txt.bz2 On 07/08/2015 01:54 PM, Markus Metzger wrote: > 2015-07-08 Markus Metzger > > gdb/ > * record-btrace.c (record_btrace_goto_begin, record_btrace_goto_end) > record_btrace_goto): Set stop_pc. Call reinit_frame_cache. > * record-full.c (record_full_goto_entry): Set stop_pc. > > testsuite/ > * gdb.btrace/record_goto-step.exp: New. > --- > gdb/record-btrace.c | 6 ++++ > gdb/record-full.c | 1 + > gdb/testsuite/gdb.btrace/record_goto-step.exp | 46 +++++++++++++++++++++++++++ > 3 files changed, 53 insertions(+) > create mode 100644 gdb/testsuite/gdb.btrace/record_goto-step.exp > > diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c > index 969e01b..3870400 100644 > --- a/gdb/record-btrace.c > +++ b/gdb/record-btrace.c > @@ -2227,6 +2227,8 @@ record_btrace_goto_begin (struct target_ops *self) > btrace_insn_begin (&begin, &tp->btrace); > record_btrace_set_replay (tp, &begin); > > + reinit_frame_cache (); > + stop_pc = regcache_read_pc (get_current_regcache ()); I think you should do this within record_btrace_set_replay, instead of doing the same in several places. Also, I don't think you need the reinit_frame_cache call, as the registers_changed_ptid calls in record_btrace_set_replay/record_btrace_stop_replaying take care of it already. Thanks, Pedro Alves