From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114092 invoked by alias); 8 Jul 2015 13:42:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114081 invoked by uid 89); 8 Jul 2015 13:42:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 13:42:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 8C9DBC796B; Wed, 8 Jul 2015 13:42:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68DgKRI009489; Wed, 8 Jul 2015 09:42:20 -0400 Message-ID: <559D28BB.9050603@redhat.com> Date: Wed, 08 Jul 2015 13:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Markus Metzger CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] btrace: fix build fail with 32-bit BFD References: <1436360074-8625-1-git-send-email-markus.t.metzger@intel.com> In-Reply-To: <1436360074-8625-1-git-send-email-markus.t.metzger@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00212.txt.bz2 On 07/08/2015 01:54 PM, Markus Metzger wrote: > When compiling GDB with 32-bit BFD, the build fails with: > > In file included from btrace.h:33:0, > from btrace.c:23: > /usr/include/intel-pt.h:1643:51: note: expected 'int (*)(uint8_t *, size_t, > const struct pt_asid *, uint64_t, void *)' but argument is of type 'int > (*)(gdb_byte *, size_t, const struct pt_asid *, CORE_ADDR, void *)' extern > pt_export int pt_image_set_callback(struct pt_image *image, ^ > > Fix it. > > 2015-07-08 Markus Metzger > > gdb/ > * btrace.c (btrace_pt_readmem_callback): Change type of PC argument. OK. Thanks, Pedro Alves