From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120735 invoked by alias); 8 Jul 2015 14:38:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120693 invoked by uid 89); 8 Jul 2015 14:37:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 14:37:57 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D2AC33798CF; Wed, 8 Jul 2015 14:37:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68Ebrho016550; Wed, 8 Jul 2015 10:37:54 -0400 Message-ID: <559D35C1.5010701@redhat.com> Date: Wed, 08 Jul 2015 14:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org CC: Aleksandar Ristovski Subject: Re: [PATCH v7 03/10] Code cleanup: Rename enum -> enum filterflags References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192606.18346.1038.stgit@host1.jankratochvil.net> In-Reply-To: <20150614192606.18346.1038.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00217.txt.bz2 On 06/14/2015 08:26 PM, Jan Kratochvil wrote: > Hi Sergio, > > this is an unrelated cleanup, bit mask ints are better to make enums as GDB > already has support to automatically decode them: > > before this patch: > (gdb) p filterflags > $1 = 51 > (gdb) p/x filterflags > $2 = 0x33 > > after this patch: > (gdb) p filterflags > $1 = (COREFILTER_ANON_PRIVATE | COREFILTER_ANON_SHARED | COREFILTER_ELF_HEADERS | COREFILTER_HUGETLB_PRIVATE) > > New patch, not yet reviewed before. OK. Thanks, Pedro Alves