From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124149-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12534 invoked by alias); 8 Jul 2015 14:44:33 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12176 invoked by uid 89); 8 Jul 2015 14:44:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 14:44:29 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (Postfix) with ESMTPS id D5C60C6599;	Wed,  8 Jul 2015 14:44:27 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68EiP48023188;	Wed, 8 Jul 2015 10:44:26 -0400
Message-ID: <559D3749.9010200@redhat.com>
Date: Wed, 08 Jul 2015 14:44:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>, Doug Evans <dje@google.com>
CC: gdb-patches <gdb-patches@sourceware.org>,        Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192655.18346.17075.stgit@host1.jankratochvil.net> <20150621101644.GA12733@host1.jankratochvil.net> <CADPb22TH5nfFSkCzW9cCiHuoJFAG+P5z=qZawgwGUgYQ5kfd5Q@mail.gmail.com> <20150623204702.GA2156@host1.jankratochvil.net>
In-Reply-To: <20150623204702.GA2156@host1.jankratochvil.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-07/txt/msg00220.txt.bz2

Jan Kratochvil wrote:

> +static char *
> +svr4_validate (const struct so_list *const so)
> +{

...

> +      return xstrprintf (_("remote build ID is %s "
> +			   "but local file does not have build ID"),
> +			 remote_hex);

Seems odd to say "remote" here.  Can't these errors trigger with native
debugging as well?

Doug Evans wrote:
> 
>> > If so, having solib in the option name is confusing.
>> > 
>> > set build-id-force
>> > or
>> > set require-build-id-match
>> > or some such would be clearer.

"build-id-force" sound odd to me.  The latter sounds OK,
as would "set build-id-validation on/off/...".

With that, and once the previous issues raised are
addressed, I think this is good to go.

Thanks,
Pedro Alves