From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117295 invoked by alias); 8 Jul 2015 15:59:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117275 invoked by uid 89); 8 Jul 2015 15:59:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Jul 2015 15:59:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 648AF3173DD; Wed, 8 Jul 2015 15:59:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t68FxA8W002362; Wed, 8 Jul 2015 11:59:11 -0400 Message-ID: <559D48CE.5030700@redhat.com> Date: Wed, 08 Jul 2015 15:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Delete program spaces directly when removing inferiors References: <1412022790-21931-1-git-send-email-simon.marchi@ericsson.com> <559D1220.1060708@redhat.com> <559D4314.2000906@ericsson.com> <559D44FF.60705@ericsson.com> In-Reply-To: <559D44FF.60705@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00228.txt.bz2 On 07/08/2015 04:42 PM, Simon Marchi wrote: > I have reverted the patch, since it causes a build failure: > > http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/77 > > delete_inferior_silent is actually used in monitor.c. What I don't understand is why > monitor.o doesn't get built when I build gdb locally. When I type "make monitor.o", > I can see the build error at least. Yeah, it's only built if you build support for a target that pulls it in. See configure.tgt, look for monitor.o. The buildbot uses --enable-targets=all, you probably didn't. We can probably just make monitor.c call discard_all_inferiors. Thanks, Pedro Alves