From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17776 invoked by alias); 9 Jul 2015 10:53:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17713 invoked by uid 89); 9 Jul 2015 10:53:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Jul 2015 10:53:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id B9C4BB1F86; Thu, 9 Jul 2015 10:53:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t69ArcvD021474; Thu, 9 Jul 2015 06:53:38 -0400 Message-ID: <559E52B1.9020802@redhat.com> Date: Thu, 09 Jul 2015 10:53:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Split c_val_print References: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1436389629-18754-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00277.txt.bz2 On 07/08/2015 10:07 PM, Simon Marchi wrote: > I think that c_val_print deserves to be split up in smaller, more > manageable chunks. This series does that, by simply factoring out each > case of the big switch. In some cases, a bit of modifications were > necessary where fallthrough between cases or goto were used, but > otherwise the code stays the same. Nice! A couple issues need to be fixed and this is good to go. - The intro comment to print_unpacked_pointer in patch 2 uses the wrong format (leading * in each line?). - For convention, make sure there's a line break after each variable declaration. Fix these and push. Thanks, Pedro Alves