From: Pierre Langlois <pierre.langlois@arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: pierre.langlois@arm.com,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 4/8] [AArch64] Teach prologue unwinder to terminate gracefully
Date: Thu, 09 Jul 2015 12:51:00 -0000 [thread overview]
Message-ID: <559E6E5F.7000604@arm.com> (raw)
In-Reply-To: <86vbdtlcqr.fsf@gmail.com>
On 09/07/15 13:46, Yao Qi wrote:
> Pierre Langlois <pierre.langlois@arm.com> writes:
>
>> +/* Allocate and fill in *THIS_CACHE with information about the prologue of
>> + *THIS_FRAME. Do not do this is if *THIS_CACHE was already allocated.
>> + Return a pointer to the current aarch64_prologue_cache in *THIS_CACHE.
>> + */
>
> We don't write */-only line in the comment. See "Block Comment Formatting"
> in https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
>
> You can change it to
> ...
> *THIS_CACHE. */
>
Oh I see, sorry I missed this. I'll update this comment on the other
patches too.
next prev parent reply other threads:[~2015-07-09 12:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 12:52 [PATCH 0/8] [AArch64] Add support for tracepoints Pierre Langlois
2015-07-07 12:52 ` [PATCH 7/8] [testsuite][AArch64] Port gdb.trace Pierre Langlois
2015-07-08 16:39 ` Yao Qi
2015-07-09 12:25 ` [PATCH v2 " Pierre Langlois
2015-07-09 15:46 ` Pierre Langlois
2015-07-07 12:52 ` [PATCH 3/8] [AArch64] Only access inferior registers when creating a frame cache Pierre Langlois
2015-07-08 16:15 ` Yao Qi
2015-07-09 15:40 ` Pierre Langlois
2015-07-07 12:53 ` [PATCH 2/8] [AArch64] Refactor aarch64_make_stub_cache Pierre Langlois
2015-07-08 16:10 ` Yao Qi
2015-07-09 10:41 ` [PATCH v2 " Pierre Langlois
2015-07-09 15:39 ` Pierre Langlois
2015-07-07 12:53 ` [PATCH 1/8] [AArch64] Refactor aarch64_make_prologue_cache Pierre Langlois
2015-07-08 16:09 ` Yao Qi
2015-07-09 10:36 ` [PATCH] " Pierre Langlois
2015-07-09 15:38 ` Pierre Langlois
2015-07-07 12:53 ` [PATCH 4/8] [AArch64] Teach prologue unwinder to terminate gracefully Pierre Langlois
2015-07-08 16:24 ` Yao Qi
2015-07-09 10:49 ` [PATCH v2 " Pierre Langlois
2015-07-09 10:53 ` Pierre Langlois
2015-07-09 10:56 ` [PATCH v3 " Pierre Langlois
2015-07-09 15:41 ` Pierre Langlois
2015-07-09 12:47 ` [PATCH v2 " Yao Qi
2015-07-09 12:51 ` Pierre Langlois [this message]
2015-07-07 12:53 ` [PATCH 5/8] [AArch64] Teach stub " Pierre Langlois
2015-07-08 16:34 ` Yao Qi
2015-07-09 11:12 ` [PATCH v2 " Pierre Langlois
2015-07-09 15:45 ` Pierre Langlois
2015-07-07 12:54 ` [PATCH 6/8] [AArch64] Implement gdbarch_gen_return_address gdbarch method Pierre Langlois
2015-07-08 16:35 ` Yao Qi
2015-07-09 15:45 ` Pierre Langlois
2015-07-07 12:58 ` [PATCH 8/8] [GDBServer][AArch64] Enable support for tracepoints Pierre Langlois
2015-07-08 16:40 ` Yao Qi
2015-07-09 15:46 ` Pierre Langlois
2015-07-08 10:57 ` [PATCH 0/8] [AArch64] Add " Pedro Alves
2015-07-08 16:42 ` Yao Qi
2015-07-09 13:16 ` [PATCH] Add NEWS entry for tracepoints support on aarch64-linux Pierre Langlois
2015-07-09 14:44 ` Eli Zaretskii
2015-07-09 15:46 ` Pierre Langlois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559E6E5F.7000604@arm.com \
--to=pierre.langlois@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).