From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111518 invoked by alias); 15 Jul 2015 14:41:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111470 invoked by uid 89); 15 Jul 2015 14:41:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Jul 2015 14:41:14 +0000 Received: by padck2 with SMTP id ck2so25180730pad.0 for ; Wed, 15 Jul 2015 07:41:12 -0700 (PDT) X-Received: by 10.70.90.42 with SMTP id bt10mr8869008pdb.60.1436971272786; Wed, 15 Jul 2015 07:41:12 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id de2sm4958994pdb.15.2015.07.15.07.41.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 07:41:12 -0700 (PDT) Message-ID: <55A670FF.7010805@gmail.com> Date: Wed, 15 Jul 2015 14:41:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pierre Langlois CC: gdb-patches@sourceware.org Subject: Re: [PATCH] [AArch64] Mark single precision pseudo registers unavailable if invalid References: <1436957554-1403-1-git-send-email-pierre.langlois@arm.com> <86mvyxjzah.fsf@gmail.com> In-Reply-To: <86mvyxjzah.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00436.txt.bz2 On 15/07/15 15:00, Yao Qi wrote: > ... when I read your patch, I am wondering why does aarch64 implement > gdbarch method pseudo_register_read_value rather than > pseudo_register_read. If we implement the pseudo_register_read, the > caller will mark the value unavailable according to its return value. > pseudo_register_read_value was added to handle partially available > registers byhttps://sourceware.org/ml/gdb-patches/2011-07/msg00351.html > but I don't think of a case that some aarch64 register is partially > available. Maybe, another fix to this problem is to implement > pseudo_register_read instead of pseudo_register_read_value. To be clear, your patch can be pushed in, as it is correct and fixes fails in tests. We can discuss and implement pseudo_register_read rather than pseudo_register_read_value for aarch64 later in the follow-up patch. -- Yao (齐尧)