From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/14] Split generic_val_print in smaller parts
Date: Thu, 23 Jul 2015 21:54:00 -0000 [thread overview]
Message-ID: <55B16288.5080300@redhat.com> (raw)
In-Reply-To: <1436978863-15125-1-git-send-email-simon.marchi@ericsson.com>
On 07/15/2015 05:47 PM, Simon Marchi wrote:
> Simon Marchi (14):
> Factor out print_unpacked_pointer from generic_val_print
> Factor out array printing code from generic_val_print
> Factor out pointer printing code from generic_val_print
> Factor out memberptr printing code from generic_val_print
> Factor out reference printing code from generic_val_print
> Factor out enum printing code from generic_val_print
> Factor out flags printing code from generic_val_print
> Factor out function/method printing code from generic_val_print
> Factor out bool printing code from generic_val_print
> Factor out int printing code from generic_val_print
> Factor out char printing code from generic_val_print
> Factor out float printing code from generic_val_print
> Factor out decfloat printing code from generic_val_print
> Factor out complex printing code from generic_val_print
I read the whole series. Patches that I didn't comment
on looked OK to me as is. The one's I commented on,
just fix them and push right ahead.
Nice cleanup! Keep 'em coming. :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-07-23 21:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 16:47 Simon Marchi
2015-07-15 16:47 ` [PATCH 06/14] Factor out enum printing code from generic_val_print Simon Marchi
2015-07-15 16:47 ` [PATCH 01/14] Factor out print_unpacked_pointer " Simon Marchi
2015-07-23 21:45 ` Pedro Alves
2015-07-24 2:29 ` Simon Marchi
2015-07-27 18:16 ` Simon Marchi
2015-07-15 16:47 ` [PATCH 04/14] Factor out memberptr printing code " Simon Marchi
2015-07-15 16:48 ` [PATCH 12/14] Factor out float " Simon Marchi
2015-07-23 21:46 ` Pedro Alves
2015-07-27 18:18 ` Simon Marchi
2015-07-15 16:48 ` [PATCH 11/14] Factor out char " Simon Marchi
2015-07-23 21:46 ` Pedro Alves
2015-07-27 18:17 ` Simon Marchi
2015-07-15 16:48 ` [PATCH 05/14] Factor out reference " Simon Marchi
2015-07-15 16:48 ` [PATCH 09/14] Factor out bool " Simon Marchi
2015-07-15 16:48 ` [PATCH 07/14] Factor out flags " Simon Marchi
2015-07-15 16:48 ` [PATCH 14/14] Factor out complex " Simon Marchi
2015-07-15 16:48 ` [PATCH 13/14] Factor out decfloat " Simon Marchi
2015-07-15 16:48 ` [PATCH 03/14] Factor out pointer " Simon Marchi
2015-07-15 16:48 ` [PATCH 08/14] Factor out function/method " Simon Marchi
2015-07-23 21:45 ` Pedro Alves
2015-07-27 18:17 ` Simon Marchi
2015-07-15 16:48 ` [PATCH 02/14] Factor out array " Simon Marchi
2015-07-15 16:48 ` [PATCH 10/14] Factor out int " Simon Marchi
2015-07-23 21:54 ` Pedro Alves [this message]
2015-07-27 18:14 ` [PATCH 00/14] Split generic_val_print in smaller parts Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B16288.5080300@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).