From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99936 invoked by alias); 24 Jul 2015 08:51:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99807 invoked by uid 89); 24 Jul 2015 08:51:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Jul 2015 08:51:20 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id AC54B3798B1; Fri, 24 Jul 2015 08:51:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6O8pIl6025185; Fri, 24 Jul 2015 04:51:18 -0400 Message-ID: <55B1FC85.2050309@redhat.com> Date: Fri, 24 Jul 2015 08:51:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] Disallow using --attach and --wrapper together. References: <1437392126-29503-1-git-send-email-yao.qi@linaro.org> <1437392126-29503-2-git-send-email-yao.qi@linaro.org> <55B16AC0.4090808@redhat.com> <86k2tqgd2c.fsf@gmail.com> In-Reply-To: <86k2tqgd2c.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00680.txt.bz2 On 07/24/2015 09:44 AM, Yao Qi wrote: > Pedro Alves writes: > >> Really not sure about this. It's reasonable to do e.g., >> alias gs="gdbserver --wrapper=/whatever/wrapper --" >> (or the equivalent wrapper shell script that execs gdbserver) >> and then always start that instead of gdbserver: >> >> sometimes: >> >> $ gs :9999 PROGRAM >> >> othertimes: >> >> $ gs --attach :9999 $pid >> >> but after the patch, the latter errors out. > > IMO, it makes sense to error out in the latter case, because --wrapper > is useless if GDBserver attaches to a process. The point was that before you could just forget about --wrapper, set it once for your target/environment, having it hidden in the script|alias-that-wraps-gdbserver. I see it the same as putting this in ~/.gdbinit: set exec-wrapper /whatever/wrapper and then doing "$ gdb -p PID", and having GDB complain about "set exec-wrapper" and "-p" being incompatible. > >> >> Plus, one can combine --attach and --multi, which means >> that the wrapper would still apply to processes spawned >> after connecting. > > I agree on this case. I withdraw this patch. > Thanks, Pedro Alves