From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43734 invoked by alias); 24 Jul 2015 11:27:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43652 invoked by uid 89); 24 Jul 2015 11:27:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Jul 2015 11:27:08 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 8786F96A8; Fri, 24 Jul 2015 11:27:07 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6OBR6F1003261; Fri, 24 Jul 2015 07:27:06 -0400 Message-ID: <55B22109.5020500@redhat.com> Date: Fri, 24 Jul 2015 11:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/5] Update comments in struct value for non-8-bits architectures References: <1437072684-26565-1-git-send-email-simon.marchi@ericsson.com> <1437072684-26565-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1437072684-26565-2-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00690.txt.bz2 On 07/16/2015 07:51 PM, Simon Marchi wrote: > gdb/ChangeLog: > > * value.c (struct value): Update comments. Looks good to me, though as mentioned in the other patch, I think these comments should be explicit in saying "host" and "target". These are central structures that people study first, and being crystal clear should help grasp the byte vs memory units concepts sooner. Thanks, Pedro Alves