From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44881 invoked by alias); 24 Jul 2015 11:27:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44807 invoked by uid 89); 24 Jul 2015 11:27:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Jul 2015 11:27:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A4A30AA1; Fri, 24 Jul 2015 11:27:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6OBRFCJ002399; Fri, 24 Jul 2015 07:27:15 -0400 Message-ID: <55B22112.5000703@redhat.com> Date: Fri, 24 Jul 2015 11:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] Introduce get_value_arch References: <1437072684-26565-1-git-send-email-simon.marchi@ericsson.com> <1437072684-26565-3-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1437072684-26565-3-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00691.txt.bz2 On 07/16/2015 07:51 PM, Simon Marchi wrote: > Similar to get_type_arch, used to get the gdbarch associated to a > struct value. > > gdb/ChangeLog: > > * value.c (get_value_arch): New function. > * value.h (get_value_arch): New declaration. LGTM, with: > --- > gdb/value.c | 6 ++++++ > gdb/value.h | 4 ++++ > 2 files changed, 10 insertions(+) > > diff --git a/gdb/value.c b/gdb/value.c > index 6314036..af354de 100644 > --- a/gdb/value.c > +++ b/gdb/value.c > @@ -340,6 +340,12 @@ struct value > VEC(range_s) *optimized_out; > }; > Missing "/* See foo.h. */ breadcrumb. > +struct gdbarch * > +get_value_arch (const struct value *value) > +{ > + return get_type_arch (value_type (value)); > +} > + Thanks, -- Pedro Alves