* [PATCH] Remove xfail in gdb.mi/mi-watch.exp
@ 2015-07-25 18:14 Simon Marchi
2015-07-26 16:59 ` Doug Evans
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2015-07-25 18:14 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
I noticed there was an unexpected pass in mi-watch.exp when running on
x86_64. Doing a bit of archeology shows that the xfail was added by
4a543da. This particular test failed on the MIPS architecture, which
the original contributor was working with. Here is the thread:
https://www.sourceware.org/ml/gdb-patches/2007-09/msg00151.html
Looking at the latest buildbot results for MIPS, it seems that it's also
an unexpected pass on that architecture. Therefore, I see no reason to
leave the xfail in place.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
---
gdb/testsuite/gdb.mi/mi-watch.exp | 4 ----
1 file changed, 4 deletions(-)
diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
index 2551d42..4f87a5a 100644
--- a/gdb/testsuite/gdb.mi/mi-watch.exp
+++ b/gdb/testsuite/gdb.mi/mi-watch.exp
@@ -131,14 +131,10 @@ proc test_watchpoint_triggering {type} {
{"" "wpt=\{number=\"2\",exp=\"C\"\},value=\{old=\".*\",new=\"3\"\}"} \
"watchpoint trigger"
- if { $type == "sw" } {
- setup_xfail *-*-*
- }
mi_execute_to "exec-continue" "watchpoint-scope" "callee3" ".*" \
".*basics.c" $line_callee3_close_brace \
{"" "wpnum=\"2\""} \
"watchpoint trigger"
- clear_xfail *-*-*
}
proc test_watchpoint_all {type} {
--
2.4.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove xfail in gdb.mi/mi-watch.exp
2015-07-25 18:14 [PATCH] Remove xfail in gdb.mi/mi-watch.exp Simon Marchi
@ 2015-07-26 16:59 ` Doug Evans
2015-07-27 19:03 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Doug Evans @ 2015-07-26 16:59 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
On Sat, Jul 25, 2015 at 11:14 AM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> I noticed there was an unexpected pass in mi-watch.exp when running on
> x86_64. Doing a bit of archeology shows that the xfail was added by
> 4a543da. This particular test failed on the MIPS architecture, which
> the original contributor was working with. Here is the thread:
>
> https://www.sourceware.org/ml/gdb-patches/2007-09/msg00151.html
>
> Looking at the latest buildbot results for MIPS, it seems that it's also
> an unexpected pass on that architecture. Therefore, I see no reason to
> leave the xfail in place.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
> ---
> gdb/testsuite/gdb.mi/mi-watch.exp | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.mi/mi-watch.exp b/gdb/testsuite/gdb.mi/mi-watch.exp
> index 2551d42..4f87a5a 100644
> --- a/gdb/testsuite/gdb.mi/mi-watch.exp
> +++ b/gdb/testsuite/gdb.mi/mi-watch.exp
> @@ -131,14 +131,10 @@ proc test_watchpoint_triggering {type} {
> {"" "wpt=\{number=\"2\",exp=\"C\"\},value=\{old=\".*\",new=\"3\"\}"} \
> "watchpoint trigger"
>
> - if { $type == "sw" } {
> - setup_xfail *-*-*
> - }
> mi_execute_to "exec-continue" "watchpoint-scope" "callee3" ".*" \
> ".*basics.c" $line_callee3_close_brace \
> {"" "wpnum=\"2\""} \
> "watchpoint trigger"
> - clear_xfail *-*-*
> }
>
> proc test_watchpoint_all {type} {
LGTM. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove xfail in gdb.mi/mi-watch.exp
2015-07-26 16:59 ` Doug Evans
@ 2015-07-27 19:03 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2015-07-27 19:03 UTC (permalink / raw)
To: Doug Evans, Simon Marchi; +Cc: gdb-patches
On 15-07-26 12:58 PM, Doug Evans wrote:
> LGTM. Thanks!
Pushed, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-27 19:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-25 18:14 [PATCH] Remove xfail in gdb.mi/mi-watch.exp Simon Marchi
2015-07-26 16:59 ` Doug Evans
2015-07-27 19:03 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).