Re: [PATCH 3/5] Introduce get_value_arch

[Pedro Alves <palves@redhat.com>]

On 07/27/2015 10:47 PM, Simon Marchi wrote:
> On 15-07-24 07:27 AM, Pedro Alves wrote:
>>> diff --git a/gdb/value.c b/gdb/value.c
>>> index 6314036..af354de 100644
>>> --- a/gdb/value.c
>>> +++ b/gdb/value.c
>>> @@ -340,6 +340,12 @@ struct value
>>>    VEC(range_s) *optimized_out;
>>>  };
>>>  
>>
>> Missing "/* See foo.h.  */ breadcrumb.
> 
> Done, updated version:
> 
> From 89ef69ae7265ae62b7c0faeb502021262c9d0103 Mon Sep 17 00:00:00 2001
> From: Simon Marchi <simon.marchi@ericsson.com>
> Date: Fri, 3 Jul 2015 14:36:44 -0400
> Subject: [PATCH] Introduce get_value_arch
> 
> Similar to get_type_arch, used to get the gdbarch associated to a
> struct value.
> 

LGTM.

> > +/* Return the gdbarch associated to the value. */

(
FWIW, to my non-native ears, "associated with" sounds more
natural.  I'd write:

/* Return the gdbarch associated with the value's type.  */
)

Thanks,
Pedro Alves